1168788 - Check for devices should check for audio or video not just audio

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Mark Banner (:standard8)]

In discussing bug 1166824 with Sevaan, we agreed that the user should only be prompted to install a device when they have neither audio nor video devices installed. If they have either then they should be allowed to make a call (e.g. if they're on a landline phone, they might want to hook up video for screen sharing, and not need audio).

I want to park the work on bug 1166824 for a few days, but getting this corrected seems to be the right thing to do before we ship the more restrictive version of the standalone.

Comment 1

[Mark Banner (:standard8)]

Attachment: Check for devices should check for audio or video not just audio.

This implements the required changes.

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8611153 [details] [diff] [review]
Check for devices should check for audio or video not just audio.

Review of attachment 8611153 [details] [diff] [review]:
-----------------------------------------------------------------

Ship it! Err, tag it!

::: browser/components/loop/content/shared/js/utils.js
@@ +328,5 @@
>      // by Google Chrome.
>      } else if ("MediaStreamTrack" in rootObject) {
>        rootObject.MediaStreamTrack.getSources(function(result) {
>          function checkForInput(device) {
> +          return device.kind === "audio" || device.kind == "video";

nit: s/==/===/

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/276bef475492

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/276bef475492