Closed Bug 1168803 Opened 9 years ago Closed 9 years ago

Add --addon option to specify add-ons to be installed

Categories

(Remote Protocol :: Marionette, defect)

defect
Not set
normal

Tracking

(firefox42 fixed)

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: stanislav.khotinok, Assigned: parkouss)

Details

(Keywords: pi-marionette-runner)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.65 Safari/537.36

Steps to reproduce:

I want to test Firefox addon with firefox-ui-tests. Running "firefox-ui-tests --help" doesn't show any possible option to specify Firefox addon, like it was done with Mozmill. It would be good to be able to specify "--addon", cause currently the only available option to test some addon is to have prebuilt Firefox profile with already injected plugin in it.
Thank you Stanislav for filing this bug! So in general this is not only for Firefox ui tests but all Marionette related tests. It would be good to get this feature into Marionette.

I assume it should be part of the BaseMarionetteOptions:
http://mxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/runner/base.py#247

When set it should be forwarded to the profile creation code by mozprofile.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Add --addon arg to specify Firefox addon in firefox-ui-tests → Add --addon option to specify add-ons to be installed
Attached patch 1168803.patchSplinter Review
So this add a new --addon option, and forward that to the marionette geckoinstance or the B2GEmulatorRunner. Also I had to add a addons name argument to the mozrunner.base.runner.BaseRunner constructor - so now mozrunner is also able to use addons when the profile given is a string.
Assignee: nobody → j.parkouss
Status: NEW → ASSIGNED
Attachment #8635135 - Flags: review?(dburns)
Attachment #8635135 - Flags: review?(dburns) → review+
https://hg.mozilla.org/mozilla-central/rev/1c9c68365592
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: