Closed Bug 1168814 Opened 5 years ago Closed 4 years ago

[Metrics] Disable the checkbox to turn off AppUsageMetrics in Settings for users where DOGFOOD=1

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:2.5+, b2g-v2.5 verified, b2g-master verified)

VERIFIED FIXED
2.2 S14 (12june)
blocking-b2g 2.5+
Tracking Status
b2g-v2.5 --- verified
b2g-master --- verified

People

(Reporter: thills, Assigned: arthurcc)

References

Details

(Whiteboard: [spark])

Attachments

(2 files)

We need to turn this off in SEttings as well.  This is to make it so that Dogfooding users cannot disable the AppUsageMetrics.

This is a follow-on from Bug 1160488
Tamara, can you take this? If not, we can ask someone else.
Flags: needinfo?(thills)
Priority: -- → P1
Whiteboard: [spark]
Attached patch WIP (no tests)Splinter Review
Hi Doug,

I have a WIP for this (see attached).  I struggled with the unit tests as I'm not familiar with settings that much.  The WIP has what needs to be done though.

Do you know who could take it?

Thanks,

-tamara
Flags: needinfo?(thills)
Arthur, Yura, can one of you help us take this to completion please?
blocking-b2g: --- → spark+
Flags: needinfo?(yzenevich)
Flags: needinfo?(arthur.chen)
I can help on this.
Assignee: nobody → arthur.chen
Flags: needinfo?(yzenevich)
Flags: needinfo?(arthur.chen)
Comment on attachment 8612677 [details] [review]
[gaia] crh0716:1168814 > mozilla-b2g:master

EJ, could you help review this simple patch? I also did a renaming on the folder. Thanks!
Attachment #8612677 - Flags: review?(ejchen)
Hi Arthur,

Would you be able to make a small change to this patch?  Based on a review of another patch, I was asked to change the flag from '1' to |true|.  So, I made this change in a few other patches.

So essentially, 'debug.performance_data.dogfooding' will be set to true instead of '1' for a dogfooding user.

Thanks,
-tamara
Flags: needinfo?(arthur.chen)
Comment on attachment 8612677 [details] [review]
[gaia] crh0716:1168814 > mozilla-b2g:master

There is no problem in code, but Arthur can you check comment 7 to see whether we need to do related changes for that ? If not, this patch is good to go, if yes, please remember to revise it before merging, thanks !!

r+
Attachment #8612677 - Flags: review?(ejchen) → review+
Thanks EJ and Tamara. The patch was updated to comment 7.
Flags: needinfo?(arthur.chen)
Keywords: checkin-needed
http://docs.taskcluster.net/tools/task-graph-inspector/#Onz3Rz0FTpmh-5tGYyYu1Q

The pull request failed to pass integration tests. It could not be landed, please try again.
http://docs.taskcluster.net/tools/task-graph-inspector/#ra11QxcQSnSYpcdP2H2u5Q

The pull request failed to pass integration tests. It could not be landed, please try again.
Arthur, can this land?
Flags: needinfo?(arthur.chen)
Ah, sure. I forgot to track the landing status.
Flags: needinfo?(arthur.chen)
Keywords: checkin-needed
Autolander is disabled now. Land manually as all tests were passed: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=a35fa529b50178b6160d295d7dc81dff51d56d04

master: 4d1f2a45c252b9a45028d280813dd5113de35fcb
Status: NEW → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
blocking-b2g: spark+ → 2.5+
Target Milestone: --- → 2.2 S14 (12june)
This issue is verified fixed on Aries dogfood debug builds. In Settings > Improve Firefox OS page, the ability to change automatically sending analytics data option is disabled completely.

Device: Aries 2.6 Master (Dogfood debug build)
BuildID: 20151113123209
Gaia: e8c15ae4e5324a210000ee0a869a962aa542009f
Gecko: faf815a0fa9b052a38bce00c0c2aa1e2c9610936
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Device: Aries 2.5
BuildID: 20151113084848
Gaia: 142a25e39196f036978e0dd6c94640bd8d4d692a
Gecko: 2ed226048f70df93060f5cbb26dba6d6b09538fb
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 44.0a2 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(jmercado)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmercado)
The Aries 2.5 is also a dogfood debug build. I forgot to label that.
You need to log in before you can comment on or make changes to this bug.