Text chat should be disabled when the other participant leaves the room

VERIFIED FIXED in Firefox 41

Status

Hello (Loop)
Client
P1
normal
Rank:
12
VERIFIED FIXED
3 years ago
2 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla41
Points:
2
Bug Flags:
firefox-backlog +
in-testsuite +

Firefox Tracking Flags

(firefox41 verified)

Details

(Whiteboard: [chat])

User Story

As a user, when I'm in a room and there is no active connection, I see:

* any text chat history from the immediate past (i.e. that's leftover from the previous uses of the room in this page load, but not from previous page loads)
* no text chat entry box, so I don't get frustrated by something I can't actually use.

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
When the room is left by either user, the text chat entry should be disabled. The display of the elements should remain the same.
Flags: qe-verify+
Flags: firefox-backlog+

Updated

3 years ago
Rank: 20
Whiteboard: [chat]

Updated

3 years ago
Assignee: nobody → dmose
Iteration: --- → 41.2 - Jun 8

Updated

3 years ago
Rank: 20 → 12
Priority: P2 → P1

Updated

3 years ago
Iteration: 41.2 - Jun 8 → 41.3 - Jun 29
It seems like the described user story sets the user up for frustration by disabling an input and giving no obvious way to re-enable it. 

What about, instead, leave the message list displayed (in case the user wants to see what was typed or click a link in it), but hide the text input?
Flags: needinfo?(standard8)
Flags: needinfo?(sfranks)
Sounds good.

Just a note that this field will always remain present when chat history is persistent.
Flags: needinfo?(sfranks)
(Assignee)

Updated

3 years ago
Flags: needinfo?(standard8)

Updated

3 years ago
User Story: (updated)
(Assignee)

Comment 3

3 years ago
Gonna steal this, as I think we should take it for the next loop-client release, and the fix is fairly easy.
Assignee: dmose → standard8
(Assignee)

Comment 4

3 years ago
Created attachment 8624211 [details] [diff] [review]
Text chat should be disabled when the other participant leaves the room.

This adds signalling to the sdk driver to tell the store when the streams are disconnected, and hence the data channel goes down. As the store now knows, the views get updated correctly.

I've also added a follow-on fix for bug 1168829 where I realised the conversation toolbar had a border when it shouldn't have done.
Attachment #8624211 - Flags: review?(mdeboer)
Comment on attachment 8624211 [details] [diff] [review]
Text chat should be disabled when the other participant leaves the room.

Review of attachment 8624211 [details] [diff] [review]:
-----------------------------------------------------------------

This patch doesn't disable/ hide the textarea when the link clicker decides to leave the room.
Attachment #8624211 - Flags: review?(mdeboer) → review-
(Assignee)

Comment 6

3 years ago
Created attachment 8624234 [details] [diff] [review]
Text chat should be disabled when the other participant leaves the room.

Doh, I'd forgotton to test for that, and I had previously thought about needing to include it in disconnectSession (otherwise we drop the callbacks before they could happen).

Also I just noticed an error in the console that actionData.urls was undefined in the textChatStore, so I've just fixed that whilst I'm in the vague area.
Attachment #8624211 - Attachment is obsolete: true
Attachment #8624234 - Flags: review?(mdeboer)
Comment on attachment 8624234 [details] [diff] [review]
Text chat should be disabled when the other participant leaves the room.

Review of attachment 8624234 [details] [diff] [review]:
-----------------------------------------------------------------

Alright, works as expected. Thanks!
Attachment #8624234 - Flags: review?(mdeboer) → review+

Comment 8

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/742f057dfbe2
https://hg.mozilla.org/mozilla-central/rev/742f057dfbe2
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
QA Contact: bogdan.maris
Tested using latest Aurora 41.0a2 across platforms (Windows 7 64-bit, Mac OS X 10.10.4 and Ubuntu 14.04 32-bit), verified that the text chat is disabled if a user exits the conversation.
Status: RESOLVED → VERIFIED
status-firefox41: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.