If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Enabling AccessibleCarets crashes Firefox when trying to input text

RESOLVED FIXED in Firefox 41

Status

()

Firefox for Android
Text Selection
--
critical
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: JanH, Assigned: capella)

Tracking

41 Branch
Firefox 41
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

(crash signature, URL)

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
This bug was filed from the Socorro interface and is 
report bp-cf793a1c-a6e0-459e-915e-3ea692150527.
=============================================================

What I did:
Enabled touchcaret.enabled and selectioncaret.enabled
--> Inputting text works fine.

Enable layout.accessiblecaret.enabled to see whether that might fix bug 1168867.
--> As soon as I tap into an input field/textarea/... in order to input some text, Firefox crashes.
(Assignee)

Comment 1

2 years ago
mmm ... yah accessiblecaret, like GeckoCaret for Android is recently new (Bug 1110039). We had no need or chance to experiment with the combination until now.

cc: tylin
Sorry that the AccessibleCaret might not as stable as Touch/SelectionCarets for now. We haven't enable it on B2G yet. If you provide the callstack with function names, I might have a chance to fix it.
(Assignee)

Comment 3

2 years ago
Created attachment 8612093 [details] [diff] [review]
bug1168881.diff

Bah! The relevent stacktrace shows I managed to slip a tiny bug past my reviewers in bug 988143  :-(

#0  0x7b20c71e in PresShell::GetSelectionCaretsVisibility (this=0x7fbd5e50, aOutVisibility=0x75bf970f) at /home/master/mozilla-central/layout/base/nsDisplayList.h:3373
#1  0x7b1edf44 in IsVisible (this=0x8600b670) at /home/master/mozilla-central/layout/base/nsCaret.cpp:287
#2  nsCaret::IsVisible (this=0x8600b670) at /home/master/mozilla-central/layout/base/nsCaret.cpp:262
#3  0x7b1edf8a in nsCaret::NotifySelectionChanged (this=0x8600b670, aDomSel=0x84bc2100, aReason=<optimized out>) at /home/master/mozilla-central/layout/base/nsCaret.cpp:582
#4  0x7b25c3ae in mozilla::dom::Selection::NotifySelectionListeners (this=0x84bc2100) at /home/master/mozilla-central/layout/generic/nsSelection.cpp:5861
#5  0x7b25c3f0 in nsFrameSelection::NotifySelectionListeners (this=<optimized out>, aType=<optimized out>) at /home/master/mozilla-central/layout/generic/nsSelection.cpp:2198
#6  0x7b26154c in mozilla::dom::Selection::RemoveAllRanges (this=0x84bc2100, aRv=...) at /home/master/mozilla-central/layout/generic/nsSelection.cpp:4612
Assignee: nobody → markcapella
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8612093 - Flags: review?(tlin)
Attachment #8612093 - Flags: review?(tlin) → review+

Comment 4

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/ef991e9a6395
(Assignee)

Comment 5

2 years ago
Super-simple fix, tested locally, broke my own rule and pushed to fx-team w/no try server first
Blocks: 1155493
https://hg.mozilla.org/mozilla-central/rev/ef991e9a6395
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
You need to log in before you can comment on or make changes to this bug.