1168881 - Enabling AccessibleCarets crashes Firefox when trying to input text

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[Jan Henning [:JanH]]

This bug was filed from the Socorro interface and is 
report bp-cf793a1c-a6e0-459e-915e-3ea692150527.
=============================================================

What I did:
Enabled touchcaret.enabled and selectioncaret.enabled
--> Inputting text works fine.

Enable layout.accessiblecaret.enabled to see whether that might fix bug 1168867.
--> As soon as I tap into an input field/textarea/... in order to input some text, Firefox crashes.

Comment 1

[Mark Capella [:capella]]

mmm ... yah accessiblecaret, like GeckoCaret for Android is recently new (Bug 1110039). We had no need or chance to experiment with the combination until now.

cc: tylin

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Sorry that the AccessibleCaret might not as stable as Touch/SelectionCarets for now. We haven't enable it on B2G yet. If you provide the callstack with function names, I might have a chance to fix it.

Comment 3

[Mark Capella [:capella]]

Attachment: bug1168881.diff

Bah! The relevent stacktrace shows I managed to slip a tiny bug past my reviewers in bug 988143  :-(

#0  0x7b20c71e in PresShell::GetSelectionCaretsVisibility (this=0x7fbd5e50, aOutVisibility=0x75bf970f) at /home/master/mozilla-central/layout/base/nsDisplayList.h:3373
#1  0x7b1edf44 in IsVisible (this=0x8600b670) at /home/master/mozilla-central/layout/base/nsCaret.cpp:287
#2  nsCaret::IsVisible (this=0x8600b670) at /home/master/mozilla-central/layout/base/nsCaret.cpp:262
#3  0x7b1edf8a in nsCaret::NotifySelectionChanged (this=0x8600b670, aDomSel=0x84bc2100, aReason=<optimized out>) at /home/master/mozilla-central/layout/base/nsCaret.cpp:582
#4  0x7b25c3ae in mozilla::dom::Selection::NotifySelectionListeners (this=0x84bc2100) at /home/master/mozilla-central/layout/generic/nsSelection.cpp:5861
#5  0x7b25c3f0 in nsFrameSelection::NotifySelectionListeners (this=<optimized out>, aType=<optimized out>) at /home/master/mozilla-central/layout/generic/nsSelection.cpp:2198
#6  0x7b26154c in mozilla::dom::Selection::RemoveAllRanges (this=0x84bc2100, aRv=...) at /home/master/mozilla-central/layout/generic/nsSelection.cpp:4612

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ef991e9a6395

Comment 5

[Mark Capella [:capella]]

Super-simple fix, tested locally, broke my own rule and pushed to fx-team w/no try server first

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ef991e9a6395