1168892 - Implement a status response for synchronizers

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, defect)

Description

[Richard Newman [:rnewman]]

It's not just success or failure.

It's:

* I couldn't sync because I was offline.
* ... or the user had no account.
* ... or we're in backoff due to server outage.
* ... or we failed recently.
* ... or we were node reassigned and we haven't implemented Bug 1167010.

It's:

* I downloaded records and I think there are more to come.
* I downloaded records and I'm done.
* There was nothing to download.

It's:

* I uploaded records.
* There was nothing to upload.

It's:

* You requested an ordinary sync, but we need to do a full sync, which will take a long time.
* You requested a sync with a restricted runtime (e.g., on exit) and we're not in a good account state (or we have lots of records to upload, or…).


And more besides.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Pull req.

Here's the minimal version of this: either we completed syncing the engine (which is all we can do now), or we have a number of reasons why we didn't start.

We can flesh this out as we add capabilities (e.g., addressing Bug 1168890).

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8611619 [details] [review]
Pull req.

I commented on GH.  I worry that `accrue` is unnecessarily complicated, but meh... c'est la vie.

Comment 3

[Richard Newman [:rnewman]]

`accrue` is a slightly clarified and extended version of the `all` implementation, fwiw.

Comment 4

[Richard Newman [:rnewman]]

https://github.com/mozilla/firefox-ios/commit/b8e7e9116ae3ffcbd64f2d326120b124639e8a30