1168915 - [System] Status Bar may display in black color with white icons inappropriately in apps

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[Oliver Nelson [:oliverthor]]

Attachment: statusbar_black.png

Description:
When the user flashes their phone to the latest nightly.user (20150527010201) and enters the Browser app, performing a search and reaching Google will change the Status Bar theme to black with white text. This color change was also observed in:
* Messages
* Dialer
* Settings
after full flashing the device, though only one repro in each of these settings. It appears to have 100% repro when the user navigates to the Browser.

Repro Steps:
1) Update phone to 20150527010201
2) Open the Browser app
3) Search for 'bears'
4) Observe Status Bar

Actual:
Status Bar color is themed black with white text

Expected:
Status Bar color is themed white with black/gray text


Environment Variables:
-------------------------------------------

Device: Flame 3.0
BuildID: 20150527010201
Gaia: 8ca93673869a64e09ed6153c5402896822dfb253
Gecko: ff2e07228041
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 41.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0
*******************************

Issue DOES NOT REPRO in 2.2 for flame devices:
Results: Status Bar color is themed white with black/gray text
Device: Flame 2.2
BuildID: 20150527002504
Gaia: 8084264c4d1e28bc33220bc7443c7425bb76dbcc
Gecko: 19fcc06fb7ab
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
-------------------------------------------

Repro Rate: 
* 5/5 (browser)
* 1/5 (messages/dialer/settings)

attachments:
video- https://youtu.be/qMjjMZ2XPfE
screenshot
log

Comment 1

[Oliver Nelson [:oliverthor]]

Attachment: logcat_20150527_1005.txt

Comment 2

[No-Jun Park [:njpark]]

I ran into this while testing the Usage app fix.  do you think it's a graphics issue?

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

I would be very surprised if this was graphics.  Are we sure this isn't done on purpose?

Comment 4

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Visible regression

Requesting a window to find the culprit.

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

B2G Inbound

Last Working
Device: Flame 3.0
BuildID: 20150526043813
Gaia: 0359bf81f96a5356dacfc07e12ca72df61cbd638
Gecko: 833be9ccdb9d
Version: 41.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

First Broken
Environmental Variables:
Device: Flame 3.0
BuildID: 20150526054415
Gaia: 28043c25ce492d5496faf5eb4842362a7e819a40
Gecko: 5ec54b5dd1e8
Version: 41.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: 0359bf81f96a5356dacfc07e12ca72df61cbd638
Gecko: 5ec54b5dd1e8

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 28043c25ce492d5496faf5eb4842362a7e819a40
Gecko: 833be9ccdb9d

https://github.com/mozilla-b2g/gaia/compare/0359bf81f96a5356dacfc07e12ca72df61cbd638...28043c25ce492d5496faf5eb4842362a7e819a40

This looks to have been caused by the landing for bug 1161607

Comment 6

[KTucker [:KTucker][Inactive 3/4/2016]]

Dale, can you take a look at this please? This might have been caused by the landing for bug 1161607.

Comment 8

[Dale Harvey (:daleharvey)]

Yeh this is due to https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/app_chrome.js#L555, seems strange that the default reverts back to black but taking a look at the best fix

Comment 10

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/30557

Hey, not sure if you would prefer false or '' for resetting to default, it seemed like '' was already being handled, this switches it to revert to the light theme when it is being reset

Comment 11

[Dale Harvey (:daleharvey)]

Comment on attachment 8621317 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/30557

Gonna add Etienne to this in case Alive isnt available

Comment 12

[Dale Harvey (:daleharvey)]

Cheers for the review

https://github.com/mozilla-b2g/gaia/commit/41314de6a43aec60539f0679f0c03103403ea926

Comment 13

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on latest Nightly build of Flame v3.0 and Nexus5 v3.0 by the STR in Comment 0.

Actual results: It displays theme white with gray text on the status bar.
See attachment: verified_v3.0.png
Reproduce rate: 0/10


Device: Flame v3.0 build(eng build, Verified)
Build ID               20150616160206
Gaia Revision          9d42e94446f2dc01b519172b6d75d81d4d435bdc
Gaia Date              2015-06-16 16:16:47
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/27caa5299f9f
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150616.194325
Firmware Date          Tue Jun 16 19:43:36 EDT 2015
Bootloader             L1TC000118D0

Device: Flame v3.0 build(user build, Verified)
Build ID               20150616010205
Gaia Revision          62ba52866f4e5ca9120dad5bfe62fc5df981dc39
Gaia Date              2015-06-15 19:09:24
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/ce863f9d8864
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150616.043025
Firmware Date          Tue Jun 16 04:30:36 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus5 v3.0 build(eng build, Verified)
Build ID               20150616160206
Gaia Revision          9d42e94446f2dc01b519172b6d75d81d4d435bdc
Gaia Date              2015-06-16 16:16:47
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/27caa5299f9f
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150616.193221
Firmware Date          Tue Jun 16 19:32:40 EDT 2015
Bootloader             HHZ12f

Comment 14

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.png