1168950 - Add the document to DoProcessRestyles profile label

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Add the document to DoProcessRestyles

This is handy for figuring what's being restyled in profiles.

Comment 1

[Boris Zbarsky [:bzbarsky]]

GetSpec on a URI can be a pretty expensive operation.  Can we somehow do that only when we're actually profiling?

Comment 2

[Jeff Muizelaar [:jrmuizel]]

(In reply to Not doing reviews right now from comment #1)
> GetSpec on a URI can be a pretty expensive operation.  Can we somehow do
> that only when we're actually profiling?

Probably. I'll investigate.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Add the document to DoProcessRestyles

Only GetSpec if needed

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8611478 [details] [diff] [review]
Add the document to DoProcessRestyles

Please:

 * go back to 2 space indentation

 * default-construct docURL instead of using "N/A"; better not to waste time copying the string when we don't need it

 * given that you're calling profiler_is_active, may as well put it around more stuff, i.e., don't even call Document()->GetDocumentURI() if it's not active.  (But still null-check it.)

 * brace single-line ifs

r=dbaron with that

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/746c3a354c39

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/746c3a354c39