Closed Bug 1168950 Opened 5 years ago Closed 5 years ago

Add the document to DoProcessRestyles profile label

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Details

Attachments

(1 file, 1 obsolete file)

This is handy for figuring what's being restyled in profiles.
Attachment #8611350 - Flags: review?(dbaron)
GetSpec on a URI can be a pretty expensive operation.  Can we somehow do that only when we're actually profiling?
(In reply to Not doing reviews right now from comment #1)
> GetSpec on a URI can be a pretty expensive operation.  Can we somehow do
> that only when we're actually profiling?

Probably. I'll investigate.
Only GetSpec if needed
Attachment #8611350 - Attachment is obsolete: true
Attachment #8611350 - Flags: review?(dbaron)
Attachment #8611478 - Flags: review?(dbaron)
Comment on attachment 8611478 [details] [diff] [review]
Add the document to DoProcessRestyles

Please:

 * go back to 2 space indentation

 * default-construct docURL instead of using "N/A"; better not to waste time copying the string when we don't need it

 * given that you're calling profiler_is_active, may as well put it around more stuff, i.e., don't even call Document()->GetDocumentURI() if it's not active.  (But still null-check it.)

 * brace single-line ifs

r=dbaron with that
Attachment #8611478 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/746c3a354c39
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.