1168954 - Unexpected "Install" button appears on add-on install progress doorhanger

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

[Tracking Requested - why for this release]:

Because we're not using the doorhanger install confirmation in 39 we shouldn't show the install button disabled in the progress doorhanger.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8611413 [details] [diff] [review]
patch

>+      }
>+      else {

nit: on one line please (according to https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Control_Structures and prevailing style in browser code)

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1046d1d11e83

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1046d1d11e83

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8611413 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: 1139656
[User impact if declined]: Beta users will see an odd disabled install button in the add-on progress dialog
[Describe test coverage new/current, TreeHerder]: Only manual testing, the feature is expected on aurora/nightly
[Risks and why]: Low risk, this is a simple pref check to hide a button.
[String/UUID change made/needed]: None

Technically we don't need this on aurora but I'd rather keep the code the same.

Comment 6

[Kate Glazko]

Tracking since it is affecting Firefox 39

Comment 7

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Comment on attachment 8611413 [details] [diff] [review]
patch

Approved for uplift to aurora and beta; this has had time on m-c and is a minor UI fix.

Comment 8

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

It would be good to verify this in 39 and 40 just to make sure we haven't done anything weird to 40.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4051f0039db9

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bb5ac2094352

Comment 11

[Vasilica Tamas, QA [:vtamas]]

Reproduced this issue on Firefox 39 Beta 1 build 1 ( 20150523155636) using Windows 7 64-bit.

Verified fixed on Firefox 39 Beta 3 (20150604162752) under Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5.

Performed Exploratory testing to make sure that no new issues were caused by this fix in Firefox 41.0a1 (2015-06-07) and Firefox 40.0a2 (2015-06-07). Tested on Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5