1168969 - [User Story] Un-pin Page

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Ben Francis [:benfrancis]]

As a user I want to un-pin a page I previously pinned by mistake

Comment 1

[ffos-browser]

A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/95560478

Comment 2

[Ben Francis [:benfrancis]]

Attachment: Unpin Page - Specification

Comment 3

[Ben Francis [:benfrancis]]

Just a note for Francis that we need a new spec for this user story now that the pin page feature has moved. Maybe long-pressing from homescreen would now be a better path?

Comment 4

[Chris Lord [:cwiiis]]

To follow the existing usage patterns in the homescreen, it might make sense for there to be an 'unpin' tray, like there are delete and edit trays on the apps panel. The user would long-press-and-hold on a pinned page and drag it to the unpin tray, which would appear at the bottom of the panel.

Comment 5

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8644333 [details]
Unpin Page - Specification

Removing outdated spec, use: https://wiki.mozilla.org/FirefoxOS/Pin_the_Web

Comment 6

[Chris Lord [:cwiiis]]

When we discussed this in the meeting, it sounded like unpinning a page was going to work like unpinning a site, but the spec still has it happening via the pinning pop-up... Is there another spec I should be looking at?

Comment 7

[Sam Foster [:sfoster] (he/him)]

This is a question for Francis, forwarding. I do know the canonical spec is the "frozen" one on the wiki, but the unpin pages section seems to be in-progress.

Comment 8

[Ben Francis [:benfrancis]]

The frozen spec is out of date now, please see this page on the latest version of the Living Document which includes the spec to unpin sites and pages by dragging them to a trash icon

https://docs.google.com/presentation/d/1t39xMPHQYzQ17KcIfDwcsMR4S21DCM_3YcIUnHbFwzU/pub#slide=id.gc510677ad_0_56

Francis, the terminology on the following page looks wrong, it says the "app" will be deleted. Unpinning a page should just mark it as un-pinned in the Places database, nothing should be deleted.

Comment 9

[Ben Francis [:benfrancis]]

Chris, does this provide the information you need to implement this MVP feature?

Comment 10

[Chris Lord [:cwiiis]]

(In reply to Ben Francis [:benfrancis] (PTO until 1st October) from comment #9)
> Chris, does this provide the information you need to implement this MVP
> feature?

yup, that's the stuff :) Thanks Ben!

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1168969-new-homescreen-unpin-page > mozilla-b2g:master

Comment 12

[Guillaume Marty [:gmarty]]

Comment on attachment 8673112 [details] [review]
[gaia] Cwiiis:bug1168969-new-homescreen-unpin-page > mozilla-b2g:master

The code looks good to me but when trying on the device, shouldn't the pin pages panel disappear when there are no pinned pages?
If you remove all the pinned pages the panel stay there, empty, but it disappear on reboot. Then it is shown again when a new page is pinned.

Comment 13

[Chris Lord [:cwiiis]]

(In reply to Guillaume Marty [:gmarty] from comment #12)
> Comment on attachment 8673112 [details] [review]
> [gaia] Cwiiis:bug1168969-new-homescreen-unpin-page > mozilla-b2g:master
> 
> The code looks good to me but when trying on the device, shouldn't the pin
> pages panel disappear when there are no pinned pages?
> If you remove all the pinned pages the panel stay there, empty, but it
> disappear on reboot. Then it is shown again when a new page is pinned.

mm, I considered handling this, but then there was talk of there being an empty pinned pages panel (with information and such), so I thought I'd hold off for now and deal with it in follow-up.

Comment 14

[Chris Lord [:cwiiis]]

Merged, will file follow-up: https://github.com/mozilla-b2g/gaia/commit/3b4ca60eb3425cdd838ef80232f706f387a41d7a

Comment 15

[Jessica]

Attachment: verify_Aries KK v2.5.3gp

This bug has been verified fail on latest Aries KK v2.5.
See attachments: verify_Aries KK v2.5.3gp and logcat_1735.txt
Reproduce rate: 5/5

Prerequisite: 
1. Enable Pinning the Web on Settings > Developer 
2. Exist some pinned pages

Repro STR:
1. Navigate to the pinned page from browser app 
2. Tap unpin option on overflow menu(...)

Actual result: There is no unpin button.


Device: Aries KK v2.5 build(Fail)
Build ID               20151018193102
Gaia Revision          f75a7e01912cee313fed92ff2089586f507b2ba5
Gaia Date              2015-10-16 13:00:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d1a89632277fbaaf470c90a35573776048988f2d
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151018.185054
Firmware Date          Sun Oct 18 18:51:02 UTC 2015
Bootloader             s1

Comment 16

[Jessica]

Hi Chris,
Please check this issue again. Thank you very much.

Comment 17

[Chris Lord [:cwiiis]]

Hi Jessica, this bug was implementing unpinning from the homescreen (navigate to pinned pages panel, long-press and hold a pinned page, drag it to the remove tray that then appears).

I think there's a different bug for unpin via overflow menu, n?benfrancis about that.

Comment 18

[Ben Francis [:benfrancis]]

Yes, that is bug 1214569