116905 - Classic: Respin icon not being displayed in tab browsing. animation circling arrow

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[[not reading bugmail]]

Modern Theme is ok, This changed upto Hewitt's Theme cleanup landing.  Classic
Theme doesn't show re-spin icon when retrieving/transfering data from a web page
using tab-browsing.  There may also be a JS problem associated, not sure though.

Comment 1

[Hakon]

*** Bug 117324 has been marked as a duplicate of this bug. ***

Comment 2

[Joe Hewitt (gone)]

-> tabbed browser

Comment 3

[Joe Hewitt (gone)]

whoops, this really is themes

Comment 4

[Lori Kaplan]

accepting for shuehan during triage. Approving nomination for 0.9.9. 

Comment 5

[Joonas]

Attachment: this should fix it

browser.css tries to load "chrome://global/skin/loading.gif" which doesn't
exist. That should be "chrome://communicator/skin/icons/loading.gif", I think.
My patch fixes this. I hope.

Comment 6

[Ian Flanigan]

*** Bug 123757 has been marked as a duplicate of this bug. ***

Comment 7

[shliang]

Comment on attachment 68794 [details] [diff] [review]
this should fix it

can you make this change on mac too? thanks.

r=shuehan

Comment 8

[Joonas]

Attachment: a mac version of the patch (untested)

I don't have a mac so I'm not sure if this works :). I downloaded a mac build
and unstuffed it. The mac version of browser.css has the error on line 28. The
diff was made with patchmaker, but I had to do some voodoo magic since mac uses
0D for "end-of-line" and Windows uses 0D 0A. I also edited the diff to point to
a mac directory. Hope this works.

Comment 9

[Joonas]

The Linux version of browser.css seems to be identical (0D 0A -> 0A) to its
Windows cousin, the error is on line 32. I just noticed that I forgot to macify
the patch file. I'll attach a mac version if you want me to... Sorry :)

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

*** Bug 125457 has been marked as a duplicate of this bug. ***

Comment 11

[mozbug1]

*** Bug 125649 has been marked as a duplicate of this bug. ***

Comment 12

[Asa Dotzler [:asa]]

addign to summary to aid in bug searches.

Comment 13

[[not reading bugmail]]

adding 0.9.9 hopefully keep it in radar.. and have you tried to ask for SR= for
win32 checkin?

Comment 14

[Joonas]

Attachment: linux/unix version (untested)

I can't confirm this (I don't have Linux either) but I think this bug is in
Linux as well. Here's another pathetic hand-made patch for your reviewing
pleasure.

Comment 15

[Joonas]

Ok, here's the deal: this is a fairly visible bug that has a fix. The fix is
_really_ easy, one line needs to be changed in one file.

Win32 patch has r=, needs sr=
Mac patch needs r= and sr=
Linux patch needs r= and sr=

Anyone? Thanks.

Comment 16

[[not reading bugmail]]

[e-mail],

you should email that last comment to [e-mail].. its the
n.p.m.reviewers newsgroup., that is the kinda rule to follow to get a
review/super review.

Thanks.

Comment 17

[Joe Hewitt (gone)]

sr=hewitt for all patches

Comment 18

[Joonas]

Could someone check this in, please? Thanks!

Comment 19

[shliang]

fixed

Comment 20

[Patty Mac]

Verified on all platforms (commercial build: 2002-02-25-08-trunk)