Closed Bug 1169067 Opened 4 years ago Closed 4 years ago

Remove master version of r.js from tree when Esprima 2.2 lands in r.js

Categories

(Firefox OS Graveyard :: Gaia::P2P Sharing, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: drs, Assigned: drs)

References

Details

(Whiteboard: [spark])

Attachments

(1 file)

See bug 1166044 comment 7.

To fix this issue, I'm temporarily including the master version of r.js into the Sharing app tree. We should remove this and use the packaged version instead, once Esprima 2.2 lands in the npm package.
requirejs 2.1.18 that uses esprima 2.2 has been released.
Assignee: nobody → drs
Status: NEW → ASSIGNED
Attachment #8615796 - Flags: review?(jdarcangelo)
Attachment #8615796 - Flags: review?(jdarcangelo) → review+
https://github.com/fxos/sharing/commit/b6392132f8173aa6e93bc369f06b7daa270caf94
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.