Closed Bug 1169130 Opened 9 years ago Closed 9 years ago

[email/backend] text/plain quote processing only detects the last line of hard-wrapped quoting lead-in lines as lead-in

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: asuth, Assigned: asuth)

References

Details

Attachments

(1 file)

Given a non-format-flowed text/plain message (presumably, no user-agent) produced by gmail that looks like so:

===
On Fri, May 22, 2015 at 11:46 AM, Randell Jesup <rjesup.news@jesup.org>
wrote:

> >As part of the effort to improve logging in gecko we'd like to introduce
> a new set of unified log levels.
===

We detect the first line of the lead-in as content and only the second line as lead-in.

This is resulting in a lot of dumb-looking snippets.

I made a test and a fix against trunk because the convoy branch is not test happy right now.  We can land this on trunk or I can just only take it on convoy.  Up once I have a bug number.
Er, gonna just see how this works on convoy for now.  No review request yet.
Assignee: nobody → bugmail
Status: NEW → ASSIGNED
The convoy branch experienced some type of quoting regression in the simplest case.  This likely could be a combination of this fix being more aggressive about eating the newline after "wrote:" and lack of a trailing newline.

However, it's clear this can't go on trunk right now, so we'll stick with it living on in convoy.  (And get Convoy some more test coverage for plaintext quote chewing reply generation.)
Blocks: 1217809
This is fixed by the landing of bug 1217809.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: