Closed
Bug 1169132
Opened 9 years ago
Closed 9 years ago
ReferenceError: setNamedTimeout is not defined in FlameGraph.js
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox40 fixed, firefox41 fixed)
RESOLVED
FIXED
Firefox 41
People
(Reporter: vporof, Assigned: vporof)
References
Details
Attachments
(1 file)
2.99 KB,
patch
|
jsantell
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Not sure when that started...
Assignee | ||
Comment 1•9 years ago
|
||
Started with bug 1121180.
Comment 2•9 years ago
|
||
Probably from migrating it from jsm to js?
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Summary: ReferenceError: setNamedTimeout is not defined in FlameGraph.jsm → ReferenceError: setNamedTimeout is not defined in FlameGraph.js
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8612085 [details] [diff] [review] fix-imports.patch Review of attachment 8612085 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/shared/widgets/AbstractTreeItem.jsm @@ +340,5 @@ > /** > * Calls the provided function on all descendants of this item until > * a truthy value is returned by the predicate. > * @param function predicate > + * @return AbstractTreeItem Unintended change, will remove.
Assignee | ||
Updated•9 years ago
|
Blocks: perf-40-uplifts
Updated•9 years ago
|
Attachment #8612085 -
Flags: review?(jsantell) → review+
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b524aa2ea971
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Comment 7•9 years ago
|
||
Comment on attachment 8612085 [details] [diff] [review] fix-imports.patch Approval Request Comment [Feature/regressing bug #]: 1167252, the new performance tool [User impact if declined]: The performance tool will log errors: 'ReferenceError: setNamedTimeout is not defined' [Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 [Risks and why]: Minor - just updating the way some things are being imported. Risk is contained within devtools performance panel flame graph widget. [String/UUID change made/needed]: None
Comment 8•9 years ago
|
||
Comment on attachment 8612085 [details] [diff] [review] fix-imports.patch See Comment 7
Attachment #8612085 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Attachment #8612085 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/0b54cd80c13e
status-firefox40:
--- → fixed
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•