Closed Bug 1169132 Opened 5 years ago Closed 5 years ago

ReferenceError: setNamedTimeout is not defined in FlameGraph.js

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect
Not set

Tracking

(firefox40 fixed, firefox41 fixed)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: vporof, Assigned: vporof)

References

Details

Attachments

(1 file)

Not sure when that started...
Started with bug 1121180.
Probably from migrating it from jsm to js?
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8612085 - Flags: review?(jsantell)
Summary: ReferenceError: setNamedTimeout is not defined in FlameGraph.jsm → ReferenceError: setNamedTimeout is not defined in FlameGraph.js
Comment on attachment 8612085 [details] [diff] [review]
fix-imports.patch

Review of attachment 8612085 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shared/widgets/AbstractTreeItem.jsm
@@ +340,5 @@
>    /**
>     * Calls the provided function on all descendants of this item until
>     * a truthy value is returned by the predicate.
>     * @param function predicate
> +   * @return AbstractTreeItem

Unintended change, will remove.
Attachment #8612085 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/b524aa2ea971
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Comment on attachment 8612085 [details] [diff] [review]
fix-imports.patch


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: The performance tool will log errors: 'ReferenceError: setNamedTimeout is not defined' 
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252
[Risks and why]: Minor - just updating the way some things are being imported. Risk is contained within devtools performance panel flame graph widget.
[String/UUID change made/needed]: None
Comment on attachment 8612085 [details] [diff] [review]
fix-imports.patch

See Comment 7
Attachment #8612085 - Flags: approval-mozilla-aurora?
Attachment #8612085 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.