ReferenceError: setNamedTimeout is not defined in FlameGraph.js

RESOLVED FIXED in Firefox 40

Status

()

Firefox
Developer Tools: Performance Tools (Profiler/Timeline)
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

unspecified
Firefox 41
Points:
---

Firefox Tracking Flags

(firefox40 fixed, firefox41 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Not sure when that started...
(Assignee)

Comment 1

3 years ago
Started with bug 1121180.
Probably from migrating it from jsm to js?
(Assignee)

Comment 3

3 years ago
Created attachment 8612085 [details] [diff] [review]
fix-imports.patch
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8612085 - Flags: review?(jsantell)
(Assignee)

Updated

3 years ago
Summary: ReferenceError: setNamedTimeout is not defined in FlameGraph.jsm → ReferenceError: setNamedTimeout is not defined in FlameGraph.js
(Assignee)

Comment 4

3 years ago
Comment on attachment 8612085 [details] [diff] [review]
fix-imports.patch

Review of attachment 8612085 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shared/widgets/AbstractTreeItem.jsm
@@ +340,5 @@
>    /**
>     * Calls the provided function on all descendants of this item until
>     * a truthy value is returned by the predicate.
>     * @param function predicate
> +   * @return AbstractTreeItem

Unintended change, will remove.
(Assignee)

Updated

3 years ago
Blocks: 1167252
Attachment #8612085 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/b524aa2ea971
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Comment on attachment 8612085 [details] [diff] [review]
fix-imports.patch


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: The performance tool will log errors: 'ReferenceError: setNamedTimeout is not defined' 
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252
[Risks and why]: Minor - just updating the way some things are being imported. Risk is contained within devtools performance panel flame graph widget.
[String/UUID change made/needed]: None
Comment on attachment 8612085 [details] [diff] [review]
fix-imports.patch

See Comment 7
Attachment #8612085 - Flags: approval-mozilla-aurora?
Attachment #8612085 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.