Closed Bug 1169135 Opened 6 years ago Closed 5 years ago

Make Graphs.jsm a require module

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect
Not set
normal

Tracking

(firefox41 fixed)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: vporof, Assigned: vporof)

References

Details

Attachments

(1 file)

No description provided.
Attached patch v1Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8612087 - Flags: review?(jsantell)
Comment on attachment 8612087 [details] [diff] [review]
v1

Review of attachment 8612087 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, let's wait a day or two to land though, so if there are any other emergency pushes to aurora, we don't have more conflicts.
Attachment #8612087 - Flags: review?(jsantell) → review+
Somehow the backup didn't get added as a comment here.  But, please wait to land this until after Bug 1167379 so that it's possible to uplift 1167379.
Depends on: 1167379
Most likely this didn't get rebased on top of Bug 1167379
https://hg.mozilla.org/mozilla-central/rev/867a54da0c2c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.