[Stingray] setInterval clock implementation sometimes skips a couple seconds

RESOLVED FIXED

Status

Firefox OS
Gaia::TV
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: yifan, Assigned: yifan)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
rexboy
: review+
Details | Review | Splinter Review
(Assignee)

Description

2 years ago
Use requestAnimationFrame to implement a more accurate clock ticking timing.
(Assignee)

Updated

2 years ago
Assignee: nobody → yliao
(Assignee)

Comment 1

2 years ago
Created attachment 8628648 [details] [review]
pull request

Change setInterval to time adjusted setTimeout.
Attachment #8628648 - Flags: review?(rexboy)
Comment on attachment 8628648 [details] [review]
pull request

Looks good to me with a comment on Github. Please consider changing it before landing.

Thanks!
Attachment #8628648 - Flags: review?(rexboy) → review+
(Assignee)

Comment 3

2 years ago
Thanks! Changes were made accordingly. Merged into master.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.