1169183 - Validation fails with an error

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[Geoff Lankow (:darktrojan)]

When uploading a XPI, the page says:

> Your add-on failed validation with 1 error.
> Unexpected server error while validating.

Using the dev tools I pulled this from the HTTP response:

> Traceback (most recent call last):
>   File "/data/mkt.prod/www/addons.mozilla.org/current/olympia/apps/devhub/tasks.py", line 43, in validator
>     result = run_validator(upload.path, listed=listed)
>   File "/data/mkt.prod/www/addons.mozilla.org/current/olympia/apps/devhub/tasks.py", line 203, in run_validator
>     listed=listed)
>   File "/data/mkt.prod/www/addons.mozilla.org/current/venv/lib/python2.7/site-packages/validator/validate.py", line 82, in validate
>     timeout=timeout)
>   File "/data/mkt.prod/www/addons.mozilla.org/current/venv/lib/python2.7/site-packages/validator/submain.py", line 95, in prepare_package
>     for_appversions)
>   File "/data/mkt.prod/www/addons.mozilla.org/current/venv/lib/python2.7/site-packages/validator/submain.py", line 166, in test_package
>     output = test_inner_package(err, package, for_appversions)
>   File "/data/mkt.prod/www/addons.mozilla.org/current/venv/lib/python2.7/site-packages/validator/submain.py", line 370, in test_inner_package
>     test_func(err, xpi_package)
>   File "/data/mkt.prod/www/addons.mozilla.org/current/venv/lib/python2.7/site-packages/validator/testcases/content.py", line 252, in test_packed_scripts
>     pollutable=reversed_script in marked_scripts)
>   File "/data/mkt.prod/www/addons.mozilla.org/current/venv/lib/python2.7/site-packages/validator/testcases/scripting.py", line 57, in test_js_file
>     t.run(tree)
>   File "/data/mkt.prod/www/addons.mozilla.org/current/venv/lib/python2.7/site-packages/validator/testcases/javascript/traverser.py", line 75, in run
>     self._traverse_node(data)
>   File "/data/mkt.prod/www/addons.mozilla.org/current/venv/lib/python2.7/site-packages/validator/testcases/javascript/traverser.py", line 184, in _traverse_node
>     map(self._traverse_node, b)
>   File "/data/mkt.prod/www/addons.mozilla.org/current/venv/lib/python2.7/site-packages/validator/testcases/javascript/traverser.py", line 165, in _traverse_node
>     action_result = action(self, node)
>   File "/data/mkt.prod/www/addons.mozilla.org/current/venv/lib/python2.7/site-packages/validator/testcases/javascript/actions.py", line 304, in _define_var
>     var_value = traverser._traverse_node(declaration["init"])
>   File "/data/mkt.prod/www/addons.mozilla.org/current/venv/lib/python2.7/site-packages/validator/testcases/javascript/traverser.py", line 165, in _traverse_node
>     action_result = action(self, node)
>   File "/data/mkt.prod/www/addons.mozilla.org/current/venv/lib/python2.7/site-packages/validator/testcases/javascript/actions.py", line 830, in _expr_binary
>     left = traverser._traverse_node(node["left"])
>   File "/data/mkt.prod/www/addons.mozilla.org/current/venv/lib/python2.7/site-packages/validator/testcases/javascript/traverser.py", line 165, in _traverse_node
>     action_result = action(self, node)
>   File "/data/mkt.prod/www/addons.mozilla.org/current/venv/lib/python2.7/site-packages/validator/testcases/javascript/actions.py", line 108, in trace_member
>     traverser=traverser, instantiate=instantiate, name=identifier)
>   File "/data/mkt.prod/www/addons.mozilla.org/current/venv/lib/python2.7/site-packages/validator/testcases/javascript/jstypes.py", line 267, in get
>     entity=value_val)
>   File "/data/mkt.prod/www/addons.mozilla.org/current/venv/lib/python2.7/site-packages/validator/testcases/javascript/traverser.py", line 286, in _build_global
>     if (not callable(entity.get("dangerous")) or
> AttributeError: 'str' object has no attribute 'get'

Comment 1

[Mathieu Agopian [:magopian]]

:kmag any idea? Also, is it expected to have access to a traceback like that?

Comment 2

[Kris Maglione [:kmag]]

Huh. That's interesting. I've never seen stack traces returned with HTTP responses before. I'm pretty sure it's not desired.

Geoff, can you please attach the XPI that's causing this error?

Thanks.

Comment 3

[Kris Maglione [:kmag]]

https://github.com/mozilla/amo-validator/pull/286

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: [e-mail]

Here's the XPI.

Comment 5

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/amo-validator/commit/03b570e9e7135073fb7375f2e24a864754dc3215