Closed Bug 1169199 Opened 4 years ago Closed 4 years ago

Linux32 warnaserr builds on Try are 64-bit builds

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox39 --- fixed
firefox40 --- fixed
firefox41 --- fixed
firefox-esr38 --- fixed

People

(Reporter: jandem, Assigned: arai)

Details

Attachments

(1 file)

I had a Try push that failed jit-tests on x64, but it also broke the linux32 warnaserr builds. An assert in MacroAssembler-x64.h, so it's a 64-bit build.

We should probably either make these real 32-bit builds, or stop running them on Try (they don't run on inbound, afaics).
Flags: needinfo?(sphink)
> ++ uname -m
> + UNAME_M=x86_64
> + MAKEFLAGS=-j4
> + '[' warnaserrdebug = arm-sim ']'
> + '[' x86_64 = x86_64 ']'
> + USE_64BIT=true

$(uname -m) returns "x86_64" here, both on linux32 and linux64 builds.

> + exec src/js/src/devtools/automation/autospider.sh --platform linux warnaserr

We should use platform instead of uname, if provided.

Try is running: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b35061377409
build fails. seems that we need to specify target system type? :/

> checking host system type... x86_64-unknown-linux-gnu
> checking target system type... x86_64-unknown-linux-gnu
> checking build system type... x86_64-unknown-linux-gnu
no luck :(
https://treeherder.mozilla.org/#/jobs?repo=try&revision=28462c8fede9

so, to cross compile on linux64 machine, we need to install packages for cross compile (g++-multilib and some more ?).

or, can we just use 32bit machine?
pushed to try with specifying target and host
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a511ac6fc8a
Also green with debug build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6e6439e638f

> + case "$platform" in
> + USE_64BIT=false
> ...
> checking host system type... i686-pc-linux-gnu
> checking target system type... i686-pc-linux-gnu
> checking build system type... i686-pc-linux-gnu
Assignee: nobody → arai.unmht
Attachment #8614267 - Flags: review?(sphink)
Comment on attachment 8614267 [details] [diff] [review]
Check platform argument on linux SpiderMonkey shell build and specify target and host on 32bit build.

Review of attachment 8614267 [details] [diff] [review]:
-----------------------------------------------------------------

messy, but seems fine for now
Attachment #8614267 - Flags: review?(sphink) → review+
https://hg.mozilla.org/mozilla-central/rev/ce85a3468e35
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Flags: needinfo?(sphink)
You need to log in before you can comment on or make changes to this bug.