Closed Bug 1169201 Opened 9 years ago Closed 9 years ago

[building block] smart-modal-dialog should dispatch will-open and will-close event

Categories

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: johnhu, Assigned: johnhu)

References

Details

Attachments

(1 file)

dispatches events.
61 bytes, text/x-github-pull-request
suchiu
: review+
Details | Review 
      No description provided.
Blocks: 1164354
No longer blocks: 1164352
No longer depends on: 1164354, 1168254, 1168745
Attached file dispatches events. — 
Sung,

I just bridged the event from smart-dialog to smart-modal-dialog. Please review it. Thanks.
Attachment #8612209 - Flags: review?(suchiu)
Comment on attachment 8612209 [details] [review]
dispatches events.

Looks good to me!
Attachment #8612209 - Flags: review?(suchiu) → review+
merged:
https://github.com/smart-components/smart-modal-dialog/commit/a5666d5deacfd5fde571a1af1e2d6d967b36fd16
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: