1169203 - Scale native themed <input type=number> spin buttons when the page is zoomed (or for HiDPI)

Status: NEW

(Core :: Layout: Form Controls, defect)

Description

[Alice0775 White]

Attachment: bug.png

Steps to reproduce:
1. open data:text/html,<input type="number">
2. Zoom in

Actual Results:
something weird appearance

Expected results
Arrow controls also zoomed like <select>

Comment 1

[Jonathan Watt [:jwatt]]

This is actually tricky since platform APIs don't give a good way to do this. Note that Chrome doesn't do a great job at this either.

Comment 2

[arni2033]

Attachment: transform-scale(3) page zoomed out (Win7).png

Chrome doesn't change arrows' width when zooming while firefox doesn't change arrows' height. At least on Win7.

Comment 3

[arni2033]

Omg, I just wanted to CC that bug in another tab

Comment 4

[Helga.Deutz]

What is the status? Is this still not addressed?

"Note that Chrome doesn't do a great job at this either."
==> Chrome does a very good job, just check how appropriately the buttons scale. So it is possible to do.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: some <input type=number> examples

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So I took this because I was thinking the problem was that GetMinimumWidgetSize implementations were returning values in device pixels when the number they had was meant to be in CSS pixels. And fixing that does appear to fix the problem -- but on second thought I don't think it's right. I think the real problem here is likely that we're relying on GetMinimumWidgetSize and making these spin buttons as small as they can possibly be drawn, when we should really give them a reasonable default size. Although I'm really not sure what's right here.

This at least fixes the buttons to scale reasonably; we still have problems with native drawing of the arrows perhaps not doing the right thing. That said, when we use native drawing of the arrows, it's not clear that platforms are going to render varying sizes very well either...

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

FWIW, I had some work in progress back when I diagnosed this that I decided to abandon.