1169229 - [Statusbar] Fix dependency between the statusbar and the icons

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[Alberto Pastor [:albertopq]]

Right now we are listening to iconcreated/iconrendered events in the statusbar for handling the priority of them. We should make sure we receive those events, even when the icon is instantiated before the statusbar.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1169229-statusbar-dependency > mozilla-b2g:master

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8613955 [details] [review]
[gaia] albertopq:1169229-statusbar-dependency > mozilla-b2g:master

Awesome, I didn't expect this kind of usage of Service... but it looks good. I will say it would be nice to test these as well:

1. Statusbar registers to Service for iconContain before BaseIcon calls render
2. Statusbar registers to Service for iconContain after BaseIcon calls render
3. BaseIcon created before Statusbar registers to Service for iconCreated
4. BaseIcon created after Statusbar registers to Service for iconCreated

But this test may be difficult to write, so it's up 2 u.

Comment 3

[Alberto Pastor [:albertopq]]

Done! 

master: https://github.com/mozilla-b2g/gaia/commit/38f2e6bfa819b1417c3cbd4299a8121f5fe4f2a0