Closed
Bug 11693
Opened 25 years ago
Closed 25 years ago
GFX widgets: adding content to empty combo boxes causes strange layouts
Categories
(Core :: XUL, defect, P3)
Tracking
()
VERIFIED
FIXED
M10
People
(Reporter: alecf, Assigned: rods)
References
Details
Attachments
(3 files)
2.30 KB,
patch
|
Details | Diff | Splinter Review | |
3.84 KB,
patch
|
Details | Diff | Splinter Review | |
669 bytes,
patch
|
Details | Diff | Splinter Review |
When combo boxes (<select> tags) are placed inside toolbars in XUL, layout gets VERY wierd. I've only reproduced this on Linux, I've asked some engineers to add comments about Windows and Mac.
Reporter | ||
Updated•25 years ago
|
Summary: GFX widgets: combo boxes inside tool bars very broken → GFX widgets: combo boxes inside tool bars very broken
Reporter | ||
Comment 1•25 years ago
|
||
Here is more details (sorry that was so brief) - all of the <option> tags are displayed below each <select> tag instead of waiting to pop up when the user clicks the combo box - the combo boxes themselves are really really wide - at least twice the width of the window itself.
Reporter | ||
Comment 2•25 years ago
|
||
oh, and for a really easy test case: - start apprunner - open messenger from the toolbar - click on the "new message" button to open the compose window (don't worry, you don't need to have mail/news set up to open these windows) The whole mail compose window is completely broken...
Updated•25 years ago
|
Assignee: trudelle → evaughan
Comment 3•25 years ago
|
||
reassigning to evaughan for triage, cc kmcclusk
Updated•25 years ago
|
Assignee: evaughan → kmcclusk
Comment 4•25 years ago
|
||
Kevin, Boxes are very well tested with all other html components. It sizes the via computed size. Can you take a look?
Updated•25 years ago
|
Assignee: kmcclusk → ramiro
Summary: GFX widgets: combo boxes inside tool bars very broken → [PP][Linux] GFX widgets: combo boxes inside tool bars very broken
Comment 5•25 years ago
|
||
I tried it on WINNT and it works. Must be a problem with native combo boxes on GTK. Marking as [PP][Linux]. Gfx-rendered selects may fix this problem but they will not be enabled as the default until M10. Ramiro, can you take a look?
Reporter | ||
Comment 6•25 years ago
|
||
This IS with GFX widgets - native widgets work just fine... when you tried it on windows, was it with GFX or native widgets?
Updated•25 years ago
|
Assignee: ramiro → rods
Comment 7•25 years ago
|
||
Oops, I used native selects, not gfx. Rod, re-assigning to you.
Reporter | ||
Updated•25 years ago
|
Severity: normal → blocker
Reporter | ||
Comment 8•25 years ago
|
||
Has anyone tried this on windows or Mac? Adding hangas, putterman and mscott to get more feedback.
Reporter | ||
Comment 9•25 years ago
|
||
raising severity to blocker because this is blocking our dogfood bug.
Comment 10•25 years ago
|
||
per our discussion in the meeting today, I'll be turning GFX widgets on today and will try things out on windows.
Comment 11•25 years ago
|
||
I tried it out on Windows and the compose window looks awful. Just like you described.
Comment 12•25 years ago
|
||
Let me add some more. It doesn't just look awful, it's unusable. In addition to what Alec stated, I'm seeing remnants of the window even when I'm in other windows in other apps.
Assignee | ||
Comment 13•25 years ago
|
||
Here is what is going (well sort of): when adding items to a select with the second parameter, the "before" element, set to null the item frames get added incorrectly to the nsComboboxFrame instead of the nsListControlFrame. The only work around for the moment is to not add item dynamically unless there is already at least one item in the list. The best thing to do for now in the mail compose window is comment out the code that dynamically reads the items from the first combo and adds them to each of the other combos, then just duplicate the contents of the first combobox in each of the remaining combos (selects). Then when I get this fixed. you can put it back the way it is now. Or just leave it, and I will work on this bug right now and try to fix it as soon as I can.
Reporter | ||
Comment 14•25 years ago
|
||
not populating the boxes dynamically is not an option because we need to populate the first combo box, which is empty, with the user's identities.
Reporter | ||
Updated•25 years ago
|
Summary: [PP][Linux] GFX widgets: combo boxes inside tool bars very broken → GFX widgets: adding content to empty combo boxes causes strange layouts
Reporter | ||
Comment 15•25 years ago
|
||
updating the title to reflect the new description
Assignee | ||
Comment 16•25 years ago
|
||
I have the fix, I am just waiting to check it in.
Reporter | ||
Comment 17•25 years ago
|
||
whoo hoo! Thanks.
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 18•25 years ago
|
||
I couldn't get checked in yesterday, and the tree is red, and the apprunner is dead on Win32 anyway. I will have to waiting to check in. Maybe later today.
Assignee | ||
Comment 19•25 years ago
|
||
Assignee | ||
Comment 20•25 years ago
|
||
Assignee | ||
Comment 21•25 years ago
|
||
Reporter | ||
Comment 22•25 years ago
|
||
thanks rod, I'll give it a try.
Reporter | ||
Comment 23•25 years ago
|
||
everything looks good and it works great except the second patch: - There is no NS_NewGfxImageControlFrame in my tree, or in LXR so it won't link. I changed it back to NS_NewImageControlFrame and it worked fine. - I think you're leaking the listFrame from GetDropdown() but I don't know if that's actually refcounted on return or not.
Reporter | ||
Comment 24•25 years ago
|
||
update: it still has some odd behavior, but its actually usable... I'm filing seperate bugs against the odd behavior
Assignee | ||
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 25•25 years ago
|
||
Sorry, about the second patch, that was work in progress you did the right thing. I just checked in the fix. Frames are not ref counted, in fatc, if you do bad things happen. I'll look into the other bugs.
Comment 26•25 years ago
|
||
Seting blank milestone to M10 since fixed now.
Comment 27•25 years ago
|
||
verified fixed on 1999-08-16-09-M9 RedHat Linux 6.0 (GNOME/enlightenment) 1999-08-25-09-M9 WinNT 4.0 sp5 1999-08-25-08-M9 MacOS 8.51 1999-08-25-13-M10 RedHat Linux 6.0 (GNOME/enlightenment) 1999-08-25-13-M10 WinNT 4.0 sp5 1999-08-25-13-M10 MacOS 8.51
Comment hidden (collapsed) |
You need to log in
before you can comment on or make changes to this bug.
Description
•