11693 - GFX widgets: adding content to empty combo boxes causes strange layouts

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Alec Flett]

When combo boxes (<select> tags) are placed inside toolbars in XUL, layout gets
VERY wierd.
I've only reproduced this on Linux, I've asked some engineers to add comments
about Windows and Mac.

Comment 1

[Alec Flett]

Here is more details (sorry that was so brief)
- all of the <option> tags are displayed below each <select> tag instead of
waiting to pop up when the user clicks the combo box
- the combo boxes themselves are really really wide - at least twice the width
of the window itself.

Comment 2

[Alec Flett]

oh, and for a really easy test case:
- start apprunner
- open messenger from the toolbar
- click on the "new message" button to open the compose window
(don't worry, you don't need to have mail/news set up to open these windows)

The whole mail compose window is completely broken...

Comment 3

[Peter Trudelle]

reassigning to evaughan for triage, cc kmcclusk

Comment 4

[Eric Vaughan]

Kevin,

Boxes are very well tested with all other html components. It sizes the via
computed size. Can you take a look?

Comment 5

[Kevin McCluskey (gone)]

I tried it on WINNT and it works. Must be a problem with native combo boxes on
GTK. Marking as [PP][Linux]. Gfx-rendered selects may fix this problem but they
will not be enabled as the default until M10.

Ramiro, can you take a look?

Comment 6

[Alec Flett]

This IS with GFX widgets - native widgets work just fine... when you tried it on
windows, was it with GFX or native widgets?

Comment 7

[Kevin McCluskey (gone)]

Oops, I used native selects, not gfx.
Rod, re-assigning to you.

Comment 8

[Alec Flett]

Has anyone tried this on windows or Mac? Adding hangas, putterman and mscott to
get more feedback.

Comment 9

[Alec Flett]

raising severity to blocker because this is blocking our dogfood bug.

Comment 10

[Scott MacGregor]

per our discussion in the meeting today, I'll be turning GFX widgets on today
and will try things out on windows.

Comment 11

[scottputterman]

I tried it out on Windows and the compose window looks awful.  Just like you
described.

Comment 12

[scottputterman]

Let me add some more.  It doesn't just look awful, it's unusable.  In addition
to what Alec stated, I'm seeing remnants of the window even when I'm in other
windows in other apps.

Comment 13

[rods (gone)]

Here is what is going (well sort of): when adding items to a select with the
second parameter, the "before" element, set to null the item frames get added
incorrectly to the nsComboboxFrame instead of the nsListControlFrame. The only
work around for the moment is to not add item dynamically unless there is
already at least one item in the list. The best thing to do for now in the mail
compose window is comment out the code that dynamically reads the items from the
first combo and adds them to each of the other combos, then just duplicate the
contents of the first combobox in each of the remaining combos (selects). Then
when I get this fixed. you can put it back the way it is now.

Or just leave it, and I will work on this bug right now and try to fix it as
soon as I can.

Comment 14

[Alec Flett]

not populating the boxes dynamically is not an option because we need to
populate the first combo box, which is empty, with the user's identities.

Comment 15

[Alec Flett]

updating the title to reflect the new description

Comment 16

[rods (gone)]

I have the fix, I am just waiting to check it in.

Comment 17

[Alec Flett]

whoo hoo! Thanks.

Comment 18

[rods (gone)]

I couldn't get checked in yesterday, and the tree is red, and the apprunner is
dead on Win32 anyway. I will have to waiting to check in. Maybe later today.

Comment 19

[rods (gone)]

Attachment: Patch #1

Comment 20

[rods (gone)]

Attachment: Patch 2/3

Comment 21

[rods (gone)]

Attachment: Patch 3/3

Comment 22

[Alec Flett]

thanks rod, I'll give it a try.

Comment 23

[Alec Flett]

everything looks good and it works great except the second patch:
- There is no NS_NewGfxImageControlFrame in my tree, or in LXR so it won't link.
I changed it back to NS_NewImageControlFrame and it worked fine.
- I think you're leaking the listFrame from GetDropdown() but I don't know if
that's actually refcounted on return or not.

Comment 24

[Alec Flett]

update: it still has some odd behavior, but its actually usable... I'm filing
seperate bugs against the odd behavior

Comment 25

[rods (gone)]

Sorry, about the second patch, that was work in progress you did the right
thing. I just checked in the fix. Frames are not ref counted, in fatc, if you do
bad things happen. I'll look into the other bugs.

Comment 26

[leger]

Seting blank milestone to M10 since fixed now.

Comment 27

[phillip]

verified fixed on

     1999-08-16-09-M9 RedHat Linux 6.0 (GNOME/enlightenment)
     1999-08-25-09-M9 WinNT 4.0 sp5
     1999-08-25-08-M9 MacOS 8.51

     1999-08-25-13-M10 RedHat Linux 6.0 (GNOME/enlightenment)
     1999-08-25-13-M10 WinNT 4.0 sp5
     1999-08-25-13-M10 MacOS 8.51

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/167c62290217
[components] Issue https://github.com/mozilla-mobile/android-components/issues/11693: Set a null default value to frecencyConfig and providerConfig in TopSitesConfig