1169312 - Missing space in expired-token error

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[Mark Côté [:mcote]]

This has been driving me crazy:

The token is not valid. It could be because you loaded this page more than3 days ago.

Seems it's a problem with the BMO template specifically.

Comment 1

[Mark Côté [:mcote]]

Attachment: Add missing space to expired-token error

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8612351 [details] [diff] [review]
Add missing space to expired-token error

Review of attachment 8612351 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 8612351 [details] [diff] [review]
Add missing space to expired-token error

Review of attachment 8612351 [details] [diff] [review]:
-----------------------------------------------------------------

::: template/en/default/global/user-error.html.tmpl
@@ +259,1 @@
>      [% constants.MAX_TOKEN_AGE FILTER html %] days ago.

You could have also done 

[%+ constants.MAX_TOKEN_AGE FILTER html %]

The + preserves whitespace before the delimiter.

Comment 4

[:glob ✱]

Comment on attachment 8612351 [details] [diff] [review]
Add missing space to expired-token error

Review of attachment 8612351 [details] [diff] [review]:
-----------------------------------------------------------------

adding trailing whitespace isn't the right way to fix this.  use [%+ or [%= please.

Comment 5

[Mark Côté [:mcote]]

Attachment: Add missing space to expired-token error, v2

Went with [%= to collapse all whitespace to a single space (interestingly, "collapse", as used in the docs, is sort of a misnomer, since it will also insert a space if there are none).

Comment 6

[:glob ✱]

Comment on attachment 8616070 [details] [diff] [review]
Add missing space to expired-token error, v2

Review of attachment 8616070 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 7

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   aff954b..a46479d  master -> master