Closed Bug 1169312 Opened 6 years ago Closed 5 years ago

Missing space in expired-token error

Categories

(bugzilla.mozilla.org :: User Interface, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: mcote, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

This has been driving me crazy:

The token is not valid. It could be because you loaded this page more than3 days ago.

Seems it's a problem with the BMO template specifically.
Attachment #8612351 - Flags: review?(dylan)
Comment on attachment 8612351 [details] [diff] [review]
Add missing space to expired-token error

Review of attachment 8612351 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan
Attachment #8612351 - Flags: review?(dylan) → review+
Comment on attachment 8612351 [details] [diff] [review]
Add missing space to expired-token error

Review of attachment 8612351 [details] [diff] [review]:
-----------------------------------------------------------------

::: template/en/default/global/user-error.html.tmpl
@@ +259,1 @@
>      [% constants.MAX_TOKEN_AGE FILTER html %] days ago.

You could have also done 

[%+ constants.MAX_TOKEN_AGE FILTER html %]

The + preserves whitespace before the delimiter.
Comment on attachment 8612351 [details] [diff] [review]
Add missing space to expired-token error

Review of attachment 8612351 [details] [diff] [review]:
-----------------------------------------------------------------

adding trailing whitespace isn't the right way to fix this.  use [%+ or [%= please.
Attachment #8612351 - Flags: review-
Went with [%= to collapse all whitespace to a single space (interestingly, "collapse", as used in the docs, is sort of a misnomer, since it will also insert a space if there are none).
Attachment #8612351 - Attachment is obsolete: true
Attachment #8616070 - Flags: review?(glob)
Comment on attachment 8616070 [details] [diff] [review]
Add missing space to expired-token error, v2

Review of attachment 8616070 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob
Attachment #8616070 - Flags: review?(glob) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   aff954b..a46479d  master -> master
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.