Closed
Bug 1169314
Opened 9 years ago
Closed 9 years ago
Pocket icons missing from Windows HiDPI menuPanel sprite
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
People
(Reporter: jaws, Assigned: jaws)
References
Details
Attachments
(4 files, 2 obsolete files)
91.53 KB,
image/png
|
Details | |
46.19 KB,
image/png
|
Details | |
177.06 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
177.14 KB,
patch
|
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Stephen, can you provide new HiDPI menuPanel sprites with the Pocket icon and inverted Pocket icon too?
Flags: qe-verify-
Flags: needinfo?(shorlander)
Flags: firefox-backlog+
Comment 1•9 years ago
|
||
Nate FYI, this is for Windows 10.
Assignee | ||
Comment 2•9 years ago
|
||
(In reply to Bryan Clark (Firefox PM) [:clarkbw] from comment #1) > Nate FYI, this is for Windows 10. This is actually for any version of Windows that is configured to use HiDPI, which I believe has been supported since Windows Vista.
Comment 4•9 years ago
|
||
(In reply to Nate Weiner from comment #3) > :Bryan Anything you need from us for this? If you have the HiDPI icons or can send Stephen sources files that would help him that might be useful. Thanks!
Flags: needinfo?(clarkbw)
Assignee | ||
Updated•9 years ago
|
Priority: -- → P1
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Bryan Clark (Firefox PM) [:clarkbw] from comment #4) > If you have the HiDPI icons or can send Stephen sources files that would > help him that might be useful. Thanks!
Iteration: 41.2 - Jun 8 → 41.3 - Jun 29
Flags: needinfo?(nate)
Comment 6•9 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5) > (In reply to Bryan Clark (Firefox PM) [:clarkbw] from comment #4) > > If you have the HiDPI icons or can send Stephen sources files that would > > help him that might be useful. Thanks! We have the Pocket icon in SVG. I don't think we would need anything else. https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/shared/reader/pocket.svg?from=pocket.svg#1
Flags: needinfo?(shorlander)
Comment 7•9 years ago
|
||
Comment 8•9 years ago
|
||
Comment 9•9 years ago
|
||
Comment 10•9 years ago
|
||
Updated•9 years ago
|
Attachment #8624900 -
Attachment is obsolete: true
Updated•9 years ago
|
Attachment #8624902 -
Attachment is obsolete: true
Updated•9 years ago
|
Flags: needinfo?(nate)
Assignee | ||
Comment 11•9 years ago
|
||
Attachment #8624916 -
Flags: review?(gijskruitbosch+bugs)
Updated•9 years ago
|
Attachment #8624916 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment 13•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/84552fc81f5f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Assignee | ||
Comment 14•9 years ago
|
||
Approval Request Comment [Feature/regressing bug #]: Windows 10 HiDPI [User impact if declined]: HiDPI icons on Windows are blurry [Describe test coverage new/current, TreeHerder]: on mozilla-central for much of 41-nightly [Risks and why]: none expected [String/UUID change made/needed]: none https://hg.mozilla.org/try/pushloghtml?changeset=71084a9edf1e
Attachment #8627203 -
Flags: approval-mozilla-beta?
Updated•9 years ago
|
status-firefox40:
--- → affected
Comment 15•9 years ago
|
||
Comment on attachment 8627203 [details] [diff] [review] Patch for 40 HiDPI sprite update. No code change. Beta+
Attachment #8627203 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in
before you can comment on or make changes to this bug.
Description
•