Closed Bug 1169314 Opened 6 years ago Closed 6 years ago

Pocket icons missing from Windows HiDPI menuPanel sprite

Categories

(Firefox :: Theme, defect, P1)

41 Branch
defect
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 41
Iteration:
41.3 - Jun 29
Tracking Status
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(4 files, 2 obsolete files)

Stephen, can you provide new HiDPI menuPanel sprites with the Pocket icon and inverted Pocket icon too?
Flags: qe-verify-
Flags: needinfo?(shorlander)
Flags: firefox-backlog+
Nate FYI, this is for Windows 10.
(In reply to Bryan Clark (Firefox PM) [:clarkbw] from comment #1)
> Nate FYI, this is for Windows 10.

This is actually for any version of Windows that is configured to use HiDPI, which I believe has been supported since Windows Vista.
:Bryan Anything you need from us for this?
Flags: needinfo?(clarkbw)
(In reply to Nate Weiner from comment #3)
> :Bryan Anything you need from us for this?

If you have the HiDPI icons or can send Stephen sources files that would help him that might be useful.  Thanks!
Flags: needinfo?(clarkbw)
Priority: -- → P1
(In reply to Bryan Clark (Firefox PM) [:clarkbw] from comment #4)
> If you have the HiDPI icons or can send Stephen sources files that would
> help him that might be useful.  Thanks!
Iteration: 41.2 - Jun 8 → 41.3 - Jun 29
Flags: needinfo?(nate)
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5)
> (In reply to Bryan Clark (Firefox PM) [:clarkbw] from comment #4)
> > If you have the HiDPI icons or can send Stephen sources files that would
> > help him that might be useful.  Thanks!

We have the Pocket icon in SVG. I don't think we would need anything else.

https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/shared/reader/pocket.svg?from=pocket.svg#1
Flags: needinfo?(shorlander)
Attached patch PatchSplinter Review
Attachment #8624916 - Flags: review?(gijskruitbosch+bugs)
Attachment #8624916 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/84552fc81f5f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Attached patch Patch for 40Splinter Review
Approval Request Comment
[Feature/regressing bug #]: Windows 10 HiDPI
[User impact if declined]: HiDPI icons on Windows are blurry
[Describe test coverage new/current, TreeHerder]: on mozilla-central for much of 41-nightly
[Risks and why]: none expected 
[String/UUID change made/needed]: none

https://hg.mozilla.org/try/pushloghtml?changeset=71084a9edf1e
Attachment #8627203 - Flags: approval-mozilla-beta?
Comment on attachment 8627203 [details] [diff] [review]
Patch for 40

HiDPI sprite update. No code change. Beta+
Attachment #8627203 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.