1169336 - Open the InterApp Communication API to unsigned (hosted/packaged) web apps

Status: RESOLVED WONTFIX

(Core Graveyard :: DOM: Apps, defect)

Description

[Carmen Jimenez Cabezas]

Currently the InterApp Communication API is restricted to certified apps only. This bug is to open (behind a preference) the IAC API to unsigned apps on a unsecure way, if the preference is set to true every app will be able to connect to any IAC port.

Comment 1

[Carmen Jimenez Cabezas]

Attachment: v1 proposed patch

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 8620826 [details] [diff] [review]
v1 proposed patch

Review of attachment 8620826 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/apps/InterAppCommService.jsm
@@ +13,5 @@
>  Cu.import("resource://gre/modules/AppsUtils.jsm");
>  
>  const DEBUG = false;
> +const DEV_MODE = !!Services.prefs.getBoolPref("dom.apps.developer_mode") ||
> +                 false;

getBoolPref() can throw if the pref is not set at all. You need something like:

const isDevMode = false;
try {
 isDevMode = Services.prefs.getBoolPref(...)
} catch(e) {}

Comment 3

[Carmen Jimenez Cabezas]

Attachment: v2 proposed patch

Comment 4

[Carmen Jimenez Cabezas]

Comment on attachment 8621767 [details] [diff] [review]
v2 proposed patch

Unit tests are being written in bug 1175154.
Try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=54c2464468da
requesting review

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8621767 [details] [diff] [review]
v2 proposed patch

This is reverted by the patch attached to bug 1169344 so no need to review or land this one.