Closed Bug 1169347 Opened 9 years ago Closed 9 years ago

Feedback form not popping up when disabling e10s on Aurora

Categories

(Firefox :: General, defect)

40 Branch
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 41
Tracking Status
firefox40 --- fixed
firefox41 --- verified

People

(Reporter: cww, Assigned: Felipe)

Details

(Whiteboard: [bugday-20150715])

Attachments

(1 file)

This is probably (almost definitely) caused by: bug 1117933

We still want to collect feedback on other pre-release channels about why users might want to disable e10s so we do need to open a tab and collect input feedback.

Unfortunately, it's not doing that right now on Aurora (by design) so we don't know why people are turning off e10s on Aurora.
STR using 40.0a2 (2015-05-28):

1. go to about:preferences
2. enable e10s
3. restart browser
4. do some stuff
5. go to about:preferences
6. disable e10s

Expected:

Firefox dev edition pops up a dialogue to tell me it's opening a tab for feedback on why I disabled e10s. Feedback tab is created.

Actual:

No dialogue and no feedback tab.
Assignee: nobody → felipc
Status: NEW → ASSIGNED
Attached patch aurorafeedbackSplinter Review
The point of the channel check was to avoid this popping up on local builds. This code is already inside an #ifdef E10S_TESTING_ONLY (which is not defined in beta/release), so I think it's enough to check for != "default". It also avoids the problem again when we expand the ifdef to Beta.
Attachment #8612491 - Flags: review?(dtownsend)
Comment on attachment 8612491 [details] [diff] [review]
aurorafeedback

Review of attachment 8612491 [details] [diff] [review]:
-----------------------------------------------------------------

Gah, no wonder we've had so little feedback!
Attachment #8612491 - Flags: review?(dtownsend) → review+
Comment on attachment 8612491 [details] [diff] [review]
aurorafeedback

Approval Request Comment
[Feature/regressing bug #]: bug 1117933
[User impact if declined]: feedback form for e10s on aurora not shown
[Describe test coverage new/current, TreeHerder]: landed on fx-team
[Risks and why]: none
[String/UUID change made/needed]: none
Attachment #8612491 - Flags: approval-mozilla-aurora?
(slightly off topic)
"Firefox Developer" https://input.mozilla.org/en-GB/feedback and aurora:help->Submit Feedback.
Both are separate from Firefox and not shown publicly on https://input.mozilla.org I guess this will be the same.
If not intentional maybe needs changing. (Not filed bug since I don't know intent.)
https://hg.mozilla.org/mozilla-central/rev/d9e538cb9139
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Comment on attachment 8612491 [details] [diff] [review]
aurorafeedback

Please don't say "None" as Risk. All patches have risks.
Attachment #8612491 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
QA Whiteboard: [good first verify][verify in Aurora only]
Successfully reproduce the bug in 40.0a2 (2015-05-28) (Build ID: 20150528004000) on Linux x64 by following comment 1's instruction!

Bug is now fixed on Latest Aurora 41.0a2 (2015-07-15)
 
Build ID: 20150715004006
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0
QA Whiteboard: [good first verify][verify in Aurora only] → [good first verify][verify in Aurora only][bugday-20150715]
Whiteboard: [bugday-20150715]
I have seen the bug following the comment 1 on windows 7, 64 bit  with Aurora 40.0a2 (2015-05-28)!

This Bugs fix is verified now on Latest Aurora 41.0a2 (2015-07-21)

Build ID : 20150721004010
User Agent : Mozilla/5.0 (Windows NT 6.1; WOW64; rv:41.0) Gecko/20100101 Firefox/41.0

As it is also verified on Linux, too (Comment 10), Marking it as verified!
Status: RESOLVED → VERIFIED
QA Whiteboard: [good first verify][verify in Aurora only][bugday-20150715] → [good first verify][verify in Aurora only][bugday-20150715][bugday-20150722]
You need to log in before you can comment on or make changes to this bug.