Closed Bug 1169349 Opened 5 years ago Closed 4 years ago

[Metrics] Replace the deviceID field in FTU with IMEI for a special build flag

Categories

(Firefox OS Graveyard :: Gaia::System, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: drs, Assigned: marshall)

References

Details

(Whiteboard: [spark])

Attachments

(1 file)

For Spark users, we want to have a special build flag that replaces the UUIDs generated for the FTU Pings with the IMEI.

This is for the dogfooding purposes.

The IMEI should be available via the telephony interfaces.
See Also: → 1160483
Tamara, now that we've landed bug 1160483, can you take this? It's our last remaining Spark dependency on the Metrics.
Flags: needinfo?(thills)
Hi Doug,

I can't do it this week.  There is a chance I can look at it next week, depending on my progress on my other project.

Also, Is this one critical?  You'll still have the usage statistics.  This just gets sent out once the phone is turned on the first time.  With the usage statistics, you'll know within 24 hours that it was turned on (since they cannot turn off the statistics with this build).

Thanks,

-tamara
Flags: needinfo?(thills)
I just had a conversation with Jean, and I'll be able to tackle this early next week after my ServiceWorker bug is wrapping up.
Marshall, Are you on track to implement this by end of the week?
Updated to work with Tamara's new TelemetryRequest.getDeviceID() function, which pulls the device IMEI for dogfooders.
Attachment #8621136 - Flags: review?(thills)
Comment on attachment 8621136 [details] [review]
use TelemetryRequest.getDeviceID()

Hi Marshall,

Something funny is going on with TelemetryRequest.  It's giving me an undefined on line 110 when I run it.  Odd, because it's listed in the globals.  I'm wondering if this is a bootstrap.js issue because I moved line 110 outside of the promise and I still get an undefined and the error then points back to bootstrap.js line 19.

-tamara
Attachment #8621136 - Flags: review?(thills)
Comment on attachment 8621136 [details] [review]
use TelemetryRequest.getDeviceID()

Hey Tamara, I think I found the issue. I moved the lazy loading of telemetry.js to ensurePing() which happens before both initSettings() and ping() are called. I tested this with and without |make dogfood| on my flame, and the behavior looks right.
Attachment #8621136 - Flags: review?(thills)
Comment on attachment 8621136 [details] [review]
use TelemetryRequest.getDeviceID()

Hi Marshall,

It looks really good.  That fixed the issue.

Thanks,

-tamara
Attachment #8621136 - Flags: review?(thills) → review+
https://github.com/mozilla-b2g/gaia/commit/a95d9af4f46edf35b5b9c59ea9bf81529d2ecb2f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
I had to revert this in https://github.com/mozilla-b2g/gaia/commit/a447f4614001b709477c505bb3e55e44f0a41936 for ftu_ping_test.js failures on Treeherder:

https://treeherder.mozilla.org/logviewer.html#?job_id=2153126&repo=b2g-inbound
Status: RESOLVED → REOPENED
Flags: needinfo?(marshall)
Resolution: FIXED → ---
I have a new PR up with the jshint fix, not sure why I didn't see this the first time around. Will merge once it looks good in treeherder.
Flags: needinfo?(marshall)
https://github.com/mozilla-b2g/gaia/commit/25799901335c6c4bfcd9afa1c8748ca23a76e0b7
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.