Closed Bug 1169349 Opened 5 years ago Closed 4 years ago
[Metrics] Replace the device
ID field in FTU with IMEI for a special build flag
For Spark users, we want to have a special build flag that replaces the UUIDs generated for the FTU Pings with the IMEI. This is for the dogfooding purposes. The IMEI should be available via the telephony interfaces.
Tamara, now that we've landed bug 1160483, can you take this? It's our last remaining Spark dependency on the Metrics.
Hi Doug, I can't do it this week. There is a chance I can look at it next week, depending on my progress on my other project. Also, Is this one critical? You'll still have the usage statistics. This just gets sent out once the phone is turned on the first time. With the usage statistics, you'll know within 24 hours that it was turned on (since they cannot turn off the statistics with this build). Thanks, -tamara
I just had a conversation with Jean, and I'll be able to tackle this early next week after my ServiceWorker bug is wrapping up.
Marshall, Are you on track to implement this by end of the week?
Updated to work with Tamara's new TelemetryRequest.getDeviceID() function, which pulls the device IMEI for dogfooders.
Comment on attachment 8621136 [details] [review] use TelemetryRequest.getDeviceID() Hi Marshall, Something funny is going on with TelemetryRequest. It's giving me an undefined on line 110 when I run it. Odd, because it's listed in the globals. I'm wondering if this is a bootstrap.js issue because I moved line 110 outside of the promise and I still get an undefined and the error then points back to bootstrap.js line 19. -tamara
Comment on attachment 8621136 [details] [review] use TelemetryRequest.getDeviceID() Hey Tamara, I think I found the issue. I moved the lazy loading of telemetry.js to ensurePing() which happens before both initSettings() and ping() are called. I tested this with and without |make dogfood| on my flame, and the behavior looks right.
Comment on attachment 8621136 [details] [review] use TelemetryRequest.getDeviceID() Hi Marshall, It looks really good. That fixed the issue. Thanks, -tamara
Attachment #8621136 - Flags: review?(thills) → review+
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
I had to revert this in https://github.com/mozilla-b2g/gaia/commit/a447f4614001b709477c505bb3e55e44f0a41936 for ftu_ping_test.js failures on Treeherder: https://treeherder.mozilla.org/logviewer.html#?job_id=2153126&repo=b2g-inbound
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I have a new PR up with the jshint fix, not sure why I didn't see this the first time around. Will merge once it looks good in treeherder.
Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.