The theme settings unit test don't check for promise rejection

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: hub, Assigned: hub)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The theme settings unit test don't check for promise rejection

Which mean they silently fail because we don't check it.

(Currently working on it)
(Assignee)

Comment 1

3 years ago
This is blocking bug 1161092
Assignee: nobody → hub
Blocks: 1161092
Created attachment 8612928 [details] [review]
[gaia] hfiguiere:bug1169363-test-fixes > mozilla-b2g:master
(Assignee)

Comment 3

3 years ago
Comment on attachment 8612928 [details] [review]
[gaia] hfiguiere:bug1169363-test-fixes > mozilla-b2g:master

Arthur,

these are fixes to the test. They were silently failing as the promise rejection was ignored. And this uncovered a lot of other tests wrongness.

Let me know if you have any question.
Attachment #8612928 - Flags: review?(arthur.chen)
Comment on attachment 8612928 [details] [review]
[gaia] hfiguiere:bug1169363-test-fixes > mozilla-b2g:master

Nice catches! Thank you for working on this. r=me.
Attachment #8612928 - Flags: review?(arthur.chen) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed
http://docs.taskcluster.net/tools/task-graph-inspector/#_dHiDHF_Rtuhq4vOIKydtQ

The pull request failed to pass integration tests. It could not be landed, please try again.
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.