1169373 - Loop server doesn't log roomConnectionId for "action":"status"

Status: RESOLVED FIXED

(Hello (Loop) :: Server, defect)

Description

[Adam Roach [:abr]]

For actions like join/leave/refresh, the loop server logging correctly includes a "roomConnectionId" field. However, for the "status" action, this field isn't currently appearing in the log output. Please update the logging code to include this field for all actions, and "status" in particular.

I recognize that this operation will likely require retrieving the room participant information from the data store; however, without this correlation, it is difficult to make use of the status information.

Once we implement the link clicker parity feature, it will become impossible to distinguish information from different clients, making the "status" data effectively worthless unless we also have roomConnectionId.

In other words, I believe that the value of this data is well worth the cost of another database hit.

Comment 1

[Rémy Hubscher (:natim)]

Attachment: Link to Github PR — #339.

Comment 2

[Adam Roach [:abr]]

Comment on attachment 8633989 [details] [review]
Link to Github PR — #339.

This looks pretty much like what I expected. I have a couple of nits that I've pointed out on github.

Comment 3

[Rémy Hubscher (:natim)]

https://github.com/mozilla-services/loop-server/commit/9266fbdfa8be2c6da09e4ce47d726ac455620345