1169375 - Version facet goes to signature report instead of adding term

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[(Away)]

https://crash-stats.mozilla.com/search/?signature=~e&release_channel=nightly&platform=Windows+NT&product=Firefox&_facets=signature&_facets=build_id&_facets=version&_facets=release_channel&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-version

Go to Version tab
Click 41.0a1

Expect: Add term 41.0a1
Actual: Leads to https://crash-stats.mozilla.com/signature/?product=Firefox&platform=Windows+NT&release_channel=nightly&signature=41.0a1&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&page=1

Comment 1

[(Away)]

It seems like bug 1152243 was landed very recently. May I request that supersearch changes spend more time on a staging server? The recent string of regressions has been frustrating, and the interruptions in my workflow are costly to Mozilla.

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to David Major [:dmajor] from comment #1)
> It seems like bug 1152243 was landed very recently. May I request that
> supersearch changes spend more time on a staging server? The recent string
> of regressions has been frustrating, and the interruptions in my workflow
> are costly to Mozilla.

We don't do UI testing as part of our normal checks against stage before pushing, but we can do better here.

Adrian, can we start needinfo?ing :dmajor when supersearch changes hit stage? We were just chatting about this in IRC and he suggested this as a way to get some additional testing before changes go live.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/cf79478241b2b89c56f5e2f30906fe9ea4791072
Bug 1169375 Make facet links add terms on supersearch

https://github.com/mozilla/socorro/commit/5c9fc40ad30b745bdc729a9045a5e12330419c53
Merge pull request #2814 from Tchanders/facetlinks

Bug 1169375 Make facet links add terms on supersearch

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

That sounds fine! Let's start right now: this fix to this problem will hit stage in a few minutes. :-)

Comment 5

[(Away)]

f+, thanks

Comment 6

[(Away)]

Any idea when this will reach prod?

Comment 7

[Robert Helmer [:rhelmer]]

(In reply to David Major [:dmajor] from comment #6)
> Any idea when this will reach prod?

We can push this today.