Closed Bug 1169376 Opened 5 years ago Closed 5 years ago

Allow getting the OuterDocAccessible for the tab's top level document

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: tbsaunde, Assigned: tbsaunde)

References

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8612446 [details] [diff] [review]
Allow getting the OuterDocAccessible for the tab's top level document

Review of attachment 8612446 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits and question

::: accessible/ipc/ProxyAccessible.cpp
@@ +970,5 @@
> +Accessible*
> +ProxyAccessible::OuterDocOfRemoteBrowser() const
> +{
> +  auto tab = static_cast<dom::TabParent*>(mDoc->Manager());
> +  dom::Element* frame = tab->GetOwnerElement();

tab is guaranteed non null?

@@ +971,5 @@
> +ProxyAccessible::OuterDocOfRemoteBrowser() const
> +{
> +  auto tab = static_cast<dom::TabParent*>(mDoc->Manager());
> +  dom::Element* frame = tab->GetOwnerElement();
> + NS_ASSERTION(frame, "why isn't the tab in a frame!");

nit, this and subsequent lines need one more space indent.

::: accessible/ipc/ProxyAccessible.h
@@ +17,5 @@
>  
>  namespace mozilla {
>  namespace a11y {
>  
> +  class Accessible;

nit: remove indent
Attachment #8612446 - Flags: review?(dbolter) → review+
(In reply to David Bolter [:davidb] from comment #2)
> Comment on attachment 8612446 [details] [diff] [review]
> Allow getting the OuterDocAccessible for the tab's top level document
> 
> Review of attachment 8612446 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me with nits and question
> 
> ::: accessible/ipc/ProxyAccessible.cpp
> @@ +970,5 @@
> > +Accessible*
> > +ProxyAccessible::OuterDocOfRemoteBrowser() const
> > +{
> > +  auto tab = static_cast<dom::TabParent*>(mDoc->Manager());
> > +  dom::Element* frame = tab->GetOwnerElement();
> 
> tab is guaranteed non null?

yes
https://hg.mozilla.org/mozilla-central/rev/042c4e999e20
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
This caused a null deref crash during Marionette e10s on elm:
https://treeherder.mozilla.org/logviewer.html#?job_id=12650&repo=elm
Assignee: nobody → tbsaunde+mozbugs
You need to log in before you can comment on or make changes to this bug.