1169389 - [Camera] Volume Button may take pictures when Geolocation Prompt is present and viewfinder is covered

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Oliver Nelson [:oliverthor]]

Attachment: logcat_20150528_1218.txt

Description:
When the user opens the Camera app for the first time, they will observe a geolocation prompt take up the entirety of the screen, thus covering the viewfinder and the shutter button. By design, the user may use the volume buttons to take pictures as a hardware shutter button. If the user taps the volume button while the geolocation prompt is present, they may still take pictures, though their view of what they are capturing is obscured.

PreReq:
* first time opening camera
--or--
* app permissions for Camera are set to 'Ask'
Repro Steps:
1) Update a Flame to 20150528140812
2) Open the Camera app
3) Observe geolocation prompt
4) Tap the volume button

Actual:
Photo is taken while user cannot see viewfinder

Expected:
User must navigate geolocation prompt before capturing photos


Environmental Variables:
----------------------------------

Device: Flame 3.0
Build ID: 20150528140812
Gaia: e7d268074ee3c9eeb191c2205c0e35992fb3915d
Gecko: 136bcd7ad566
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 41.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0
***********************

Issue DOES NOT REPRO on 2.2 for flame devices; different behavior
Results: Camera cannot use volume buttons as hardware shutter button
Device: Flame 2.2
BuildID: 20150528002504
Gaia: 999bc627063d16c20f703e702f31a5cf0da8b4a6
Gecko: 351101ec82ba
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
----------------------------------

Repro frequency: 5/5
See attached: 
video- https://youtu.be/rs-z2EfgfG8
logcat

Comment 1

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Functional regression

Requesting a window.

Comment 2

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is NOT a regression.  The volume button acting as a shutter button is a new feature for 3.0 build only.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150529063340
Gaia: a0d4c222c1f1a8d2954539dac1537a1166aab320
Gecko: 9738f055d98c
Version: 41.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Environmental Variables:
Device: Flame 2.2 
BuildID: 20150529051139
Gaia: ef9efcc658321f3d7dce27e3e423caf6dcb0f388
Gecko: ff7b17af990a
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 3

[Peter Bylenga [:PBylenga]]

Flagging UX to review, we're able to take pictures with viewfinder not in the foreground.

Comment 4

[Tiffanie Shakespeare [:tif]]

re-assigning to myself. I'll try to take a look this week. Sorry for the delay.

Comment 5

[Tiffanie Shakespeare [:tif]]

I agree with the expected as in the first comment. Volume keys should not be capturing photos when there is a dialogue or menu obscuring the viewfinder.

Comment 6

[No-Jun Park [:njpark]]

[Blocking Requested - why for this release]:
I'd like to block it, although worst it can happen is taking a mystery photo, but leaving this would give an unpolished look to the product.

Comment 7

[Michael:mtreese]

edge case - looks bad and should be fixed, but should not block release

Comment 8

[No-Jun Park [:njpark]]

[Tracking Requested - why for this release]:
Per comment 7

Comment 9

[BMO Automation]

Firefox OS is not being worked on