[Camera][HDR] Flash is not re-enabled when turning HDR off

NEW
Assigned to

Status

Firefox OS
Gaia::Camera
--
enhancement
3 years ago
3 years ago

People

(Reporter: DerekH, Assigned: dmarcos)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-master affected)

Details

(Whiteboard: [3.0-Daily-Testing][spark][3.0 feature][media], URL)

Attachments

(1 attachment)

Created attachment 8612547 [details]
HDR Logcat

Description:
The flash settings are not remembered when toggling HDR. If the user has their flash set to "on", "auto", or "off" before turning HDR on, the flash settings will remain "off" when disabling HDR no matter what setting was set previously


Repro Steps:
1) Update a Xperia Z3 Compact (B2G) to 20150526220312
2) Open Camera app> Turn on Flash
3) Tap on drawer Icon> Select HDR> Select On
4) Observe flash status
5) Tap on drawer Icon> Select HDR> Select Off
6) Observe flash status


Actual:
Flash is deactivated when HDR is turned on. However, whn HDR is turned off the flash does not turn back on. The camera app does not remember flash settings.


Expected:
The flash settings are returned to the state they were in before HDR deactivated flash when enabled


Environmental Variables:
Device: Xperia Z3 Compact (B2G) 3.0
Build ID: 20150526220312
Gaia: b168b4e2b04ecc2c0a6dcd591679d7694128fb32
Gecko: cafc8056bea143c379643eb9d7c502cc9a2cac25
Version: 41.0a1 (3.0)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0


Repro frequency: 
See attached: Logcat, Video - https://youtu.be/PtDTjA4FyqE
This issue DOES occur on Flame 3.0 (512mb)

Flash is deactivated when HDR is turned on. However, when HDR is turned off the flash does not turn back on. The camera app does not remember flash settings.

Environmental Variables:
Device: Flame 3.0 (512mb)(Kitkat)(Full Flash)
Build ID: 20150528143550
Gaia: e7d268074ee3c9eeb191c2205c0e35992fb3915d
Gecko: f986e55c4e0b
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 41.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

============================================================================================

HDR is not available on Flame 2.2 so I was unable to test this build.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
NI on component owner for nomination decision and assignment.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga) → needinfo?(npark)
Andrew, I think we can set this as a 3.0 blocker nom, since it should retain the original setting after disabling the HDR, but not sure how serious it is, what do you think?
Flags: needinfo?(npark) → needinfo?(aosmond)
UX team: what would be the correct behavior in such case?  should the setting be reverted to have the flash enabled upon disabling HDR?  Pinging :tif for insight.
Flags: needinfo?(tshakespeare)

Updated

3 years ago
Flags: needinfo?(aosmond)
The actual, as stated in the first comment, is as designed. That's not to say we can't improve the behaviour, but this is going to be an enhancement not a bug fix. 

Let me try to figure out who the PM is taking over for Steph. (insert tears here :( )
Flags: needinfo?(tshakespeare)

Comment 6

3 years ago
Diego,

Can you please take this small enhancement for next release? Assigning it to you.

Thanks
Hema
Assignee: nobody → dmarcos
Severity: normal → enhancement
Whiteboard: [3.0-Daily-Testing][spark] → [3.0-Daily-Testing][spark][3.0 feature][media]
(In reply to Tiffanie Shakespeare from comment #5)
> The actual, as stated in the first comment, is as designed. That's not to
> say we can't improve the behaviour, but this is going to be an enhancement
> not a bug fix. 
> 
> Let me try to figure out who the PM is taking over for Steph. (insert tears
> here :( )

The other bit I was wondering was the reverse case. If we instead enable flash, it will disable HDR. Should disabling flash re-enable HDR if previously disabled?
You need to log in before you can comment on or make changes to this bug.