1169470 - we should remove the old dogfood apps: Crystal skull, Cubevid, Feedback

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: logcat.txt

1. download build and flash from : https://tools.taskcluster.net/task-inspector/#xRVy3KtOQdKKP1gu0quJIw/0
2. launch crystal skull

Expected: a crystal skull that rotates.
Actual: black screen.

Note: spoke with Doug, we should probably just remove the old dogfood apps.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: github PR 30299

Not too sure who I should have review a patch like this...Since we're reusing the dogfood flag, we need to clean up the dogfood apps so it's just the apps we want for dogfooding initially.

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

[Blocking Requested - why for this release]: need dogfood build cleanup.

Comment 3

[Doug Sherk (:drs) (inactive)]

We should probably just remove the whole |DOGFOOD=1| apps list and code that handles it from the build. I think that, from now on, we should use distributions for including/removing apps instead.

Tim, do you have any thoughts on this?

Comment 4

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8612624 [details] [review]
github PR 30299

This isn't ready to go yet, so I'm dropping the review request.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I have no opinion on this and I don't know if there are still use cases for these apps. I would recommend you ask around on dev-b2g and dev-gaia first.

Comment 7

[Doug Sherk (:drs) (inactive)]

Naoki, do you have the knowledge and bandwidth to take this patch to completion? If not, I'll take it.

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I guess I should get clarity on the ask here.

If we want to remove them from the tree, I would have to do a removal from the tree patch.

apps/* is needed for the basic apps to be in the dogfood build to get all the apps in, I think.
outoftree_apps/* is in both Production and Engineering

I think the only other removable item would be : external-dogfood-apps/*
I think that's so that if people wanted more external-dogfood-apps from a different branch they can easily add it there in their own local repo.

1) Should we remove all 3 of the apps from the devapps : https://github.com/mozilla-b2g/gaia/tree/master/dev_apps as well?
2) should we remove the line : external-dogfood-apps/* ?

I'll revamp my patch to reflect this if this is the case.

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

drs to reassign the bug, as we're going to get rid of the apps in the branch, the dogfood list and the dependencies related to the dogfood list.

Comment 10

[Doug Sherk (:drs) (inactive)]

This has increased in scope a bit, and it seems that we should do the following things in this bug:

1. Remove the 'apps-dogfood.list' file: https://github.com/mozilla-b2g/gaia/blob/f34ce82a840ad3c0aed3bfff18517b3f6a0eb37f/build/config/phone/apps-dogfood.list
2. Remove the code that associates the |DOGFOOD=1| build flag with the 'apps-dogfood.list' file. This is no longer needed, as we can pull in additional apps using the customizations framework.
3. Remove each of the apps named in the summary entirely from the tree. They're all completely broken, and nobody replied to my post on dev-gaia asking if they were still in use: https://groups.google.com/forum/#!topic/mozilla.dev.gaia/P-P2pEbZRrc

George, Ricky, do you either of you have bandwidth to take this? Thanks for any help you can provide.

Comment 11

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi Kevin,

could you advise on comment 10 since you have review patch for dev_apps/feedback?
I'm not sure if we 're still using those dogfood apps since they're totally broken now and whether we can totally replace apps-dogfood.list with customizations.

Comment 12

[Doug Sherk (:drs) (inactive)]

Hi George. Kevin is on PTO for 2 weeks, so I don't think he'll be answering this. As I mentioned in comment 10, point 3, I asked on dev-gaia about this and nobody replied.

The Feedback app points to a website that has since gone down. Naoki and I talked about standing up a Google Form in its place if we ever want to do something similar again. Right now we don't, but if we did, we would use the Spark customization instead of a build flag.

Comment 13

[Ricky Chien [:rickychien] (inactive)]

I've no objections on this since this part of changes doesn't review by George and me. I think it's fine to land due to no body replying in dev-gaia.

Comment 14

[Kevin Grandon :kgrandon]

Sounds good to remove them. THanks.

Comment 15

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8612624 [details] [review]
github PR 30299

Hi Ricky,
it seems that removing those apps are ok to most of people. Please kindly review it, thanks.

Comment 16

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8612624 [details] [review]
github PR 30299

LGTM.

Comment 17

[(Inactive after June) George Duan [:gduan] [:喬智]]

thanks,
master: https://github.com/mozilla-b2g/gaia/commit/ea27c4ed5b6083c9e21d233d4804372ac4d5d353

Comment 18

[Zibi Braniecki [:zbraniecki][:gandalf]]

So, it seems that those apps are still in tree - https://github.com/mozilla-b2g/gaia/tree/master/dev_apps/crystalskull etc.

I thought we want to remove them from the tree, not just references to them in build configs?

Comment 19

[Zibi Braniecki [:zbraniecki][:gandalf]]

:gduan - comment 18?

Comment 20

[(Inactive after June) George Duan [:gduan] [:喬智]]

ok, remove them,
https://github.com/mozilla-b2g/gaia/commit/5804506d493e1eb1546f25192a329acb71834e7c

Comment 21

[Pi Wei Cheng [:piwei] (inactive)]

This issue is verified fixed on Aries 2.5 and Aries central. Crystal skull, Cubevid, and Feedback apps are not available on the Homescreen.

Device: Aries 2.5
BuildID: 20151113084848
Gaia: 142a25e39196f036978e0dd6c94640bd8d4d692a
Gecko: 2ed226048f70df93060f5cbb26dba6d6b09538fb
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 44.0a2 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Device: Aries 2.6 Master
BuildID: 20151113123209
Gaia: e8c15ae4e5324a210000ee0a869a962aa542009f
Gecko: faf815a0fa9b052a38bce00c0c2aa1e2c9610936
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0