1169486 - Consider disabling experiments.logging.dump in prefs_general due to Browser.Experiments.Experiments spew

Status: RESOLVED WORKSFORME

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Matthew N. [:MattN]]

Browser.Experiments.Experiments logging is the noisiest in test logs for non-debug builds since it dumps 10 lines at startup and 10 lines at shutdown. This makes it harder to find failures in logs locally and wastes a lot of developer time while debugging/writing tests as it makes me have to scroll back instead of just glancing at the console.

It seems like it was added to debug an issue in bug 995027 but it's not clear if it's still providing value or that it needs to run in all suites affected by prefs_general for both non-debug and debug builds. i.e. does the current value justify the cost? If a new bug arises, a try push with the pref flipped again could be used for debugging instead of making all developers wade though the output.

An alternative would be to change experiments.logging.level to Info so only one line of output appears at shutdown.

== Startup ==
1432858903592	Browser.Experiments.Experiments	TRACE	Experiments #0::enabled=true, true
1432858903593	Browser.Experiments.Experiments	TRACE	Experiments #0::Registering instance with Addon Manager.
1432858903593	Browser.Experiments.Experiments	TRACE	Experiments #0::Registering previous experiment add-on provider.
1432858903593	Browser.Experiments.Experiments	TRACE	PreviousExperimentProvider #0::startup()
1432858903594	Browser.Experiments.Experiments	TRACE	Experiments #0::_loadFromCache
1432858903716	Browser.Experiments.Experiments	TRACE	Experiments #0::_loadTask finished ok
1432858903716	Browser.Experiments.Experiments	TRACE	Experiments #0::_run
1432858903717	Browser.Experiments.Experiments	TRACE	Experiments #0::_main iteration
1432858903717	Browser.Experiments.Experiments	TRACE	Experiments #0::_evaluateExperiments
1432858903718	Browser.Experiments.Experiments	TRACE	Experiments #0::_main finished, scheduling next run

== Shutdown ==
1432858908257	Browser.Experiments.Experiments	TRACE	Experiments #0::uninit: started
1432858908257	Browser.Experiments.Experiments	TRACE	Experiments #0::uninit: finished with _loadTask
1432858908257	Browser.Experiments.Experiments	TRACE	Experiments #0::uninit: no previous shutdown
1432858908257	Browser.Experiments.Experiments	TRACE	Experiments #0::Unregistering instance with Addon Manager.
1432858908257	Browser.Experiments.Experiments	TRACE	Experiments #0::Removing install listener from add-on manager.
1432858908257	Browser.Experiments.Experiments	TRACE	Experiments #0::Removing addon listener from add-on manager.
1432858908257	Browser.Experiments.Experiments	TRACE	Experiments #0::Finished unregistering with addon manager.
1432858908257	Browser.Experiments.Experiments	TRACE	Experiments #0::Unregistering previous experiment add-on provider.
1432858908258	Browser.Experiments.Experiments	INFO	Experiments #0::Completed uninitialization.
1432858908258	Browser.Experiments.Experiments	TRACE	PreviousExperimentProvider #0::shutdown()

Comment 1

[Benjamin Smedberg]

301 Georg

Comment 2

[Georg Fritzsche [:gfritzsche]]

Good point - i don't think this has much value now, let's lower this to "Info" or "Warn".

Comment 3

[Georg Fritzsche [:gfritzsche]]

We currently fall back to the "Trace" level and don't override it for tests anymore.