1169567 - Firefox Font Preference menu does not modify preference options

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Frédéric Wang (:fredw)]

Trying to use the preference menu to change the font for a language (e.g. cyrillic) does not seem to change the preference option.

When I initially uploaded a patch for bug 1160456 on 2015-05-08 and when Karl tested it on 2015-05-20, the preference menu was still working. The potential change I see in the hg history is bug 1166161 (committed the 23rd).

FYI, the corresponding menu for SeaMonkey still worked when I asked review for the patch of bug 1160455.

Comment 1

[:Gijs (he/him)]

Hector, this seems broken. Can you investigate?

FWIW, Frédéric, it seems to work for some languages but not others... the bug would probably benefit from exact STR...

Comment 2

[Frédéric Wang (:fredw)]

Step to reproduce:

1) Go to about:preferences
2) Select the "Content" tab
3) Click on the "Advanced" button
4) In "Fonts for", select Cyrillic
5) Change "Serif" to an arbitrary font
6) Click OK to validate the changes
7) Open about:config
8) Check font.name.serif.x-cyrillic

Expected result:

font.name.serif.x-cyrillic should be set to the value selected at step 5)

Actual result:

font.name.serif.x-cyrillic remains unchanged

I'm now trying to extract a regression window...

Comment 3

[Frédéric Wang (:fredw)]

So it seems that bug 1166161 is not the culprit here.

Last good revision: cc15c275b1e3
First bad revision: ac277e615f8f
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=cc15c275b1e3&tochange=ac277e615f8f

Comment 4

[Alice0775 White]

I have a different range.

Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=4db392b8bed0&tochange=9defb2f73316

REGRESSED BY:
e734bdd5e82b	Gijs Kruitbosch — Bug 1008169 - Font selection and font size dropdowns are reacting very slowly on press up/down,r=jaws

Comment 5

[Frédéric Wang (:fredw)]

Thanks, that seems more probable. Any reason why you removed "blocks 1160456"?

Comment 6

[Alice0775 White]

Bug 1160456 is only adding a menu. So, I think that this bug not depended on bug 1160456.

Comment 7

[Frédéric Wang (:fredw)]

> So, I think that this bug not depended on bug 1160456.

Well, the relation was in the reverse order: bug 1160456 (add a new font preference) depended on this bug (font preference broken). However, it's true that the patch of bug 1160456 can be taken without repairing the font preference, it's just that it won't be possible to test it...

Comment 8

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1169567 - always arm deferredtask, r?dao

Bug 1169567 - always arm deferredtask, r?dao

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 8613429 [details]
MozReview Request: Bug 1169567 - always arm deferredtask, r?dao

not really sure what this code is about, but rs=me

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a799d07cc6e6

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a799d07cc6e6

Comment 12

[:Gijs (he/him)]

Frédéric, can you confirm that a build with this fix (for example,

http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-macosx64/1433294447/
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/1433294447/
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win64/1433294447/

) fixes the problem for you?

Comment 13

[Frédéric Wang (:fredw)]

(In reply to :Gijs Kruitbosch from comment #12)
> Frédéric, can you confirm that a build with this fix (for example,
> 
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-
> central-macosx64/1433294447/
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-
> central-win32/1433294447/
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-
> central-win64/1433294447/
> 
> ) fixes the problem for you?

Are you asking specifically on Windows or Mac (I'm using Linux but can try a Windows VM if necessary)?

I will rebuild Nightly from the latest mozilla-cental now and will tell you if that solves the problem.

Comment 14

[:Gijs (he/him)]

(In reply to Frédéric Wang (:fredw) from comment #13)
> (In reply to :Gijs Kruitbosch from comment #12)
> > Frédéric, can you confirm that a build with this fix (for example,
> > 
> > http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-
> > central-macosx64/1433294447/
> > http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-
> > central-win32/1433294447/
> > http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-
> > central-win64/1433294447/
> > 
> > ) fixes the problem for you?
> 
> Are you asking specifically on Windows or Mac (I'm using Linux but can try a
> Windows VM if necessary)?
> 
> I will rebuild Nightly from the latest mozilla-cental now and will tell you
> if that solves the problem.

No, sorry, bugzilla no longer says which platform people use when they report a bug, and I got lazy finding and copying all the links to builds (and guessed our most popular platforms). There are other mozilla-central builds for linux 32 / 64 bit already that have the patch, that you could also use, if that's faster than rebuilding ( http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-linux/1433345925/ and http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-linux64/1433345925/ , for instance)

Comment 15

[Frédéric Wang (:fredw)]

No problem, I intended to rebuild to test bug 1160456 anyway.

Yes, this fixes the problem for me. Thanks!

Comment 16

[UKS]

Hi, is this bug still to be tested on latest Aurora build?

Comment 17

[Frédéric Wang (:fredw)]

(In reply to UKS from comment #16)
> Hi, is this bug still to be tested on latest Aurora build?

I tested the patch when it landed in Nightly and also verified that the font preference menu works in the latest release. I don't know what are the QA rules, but I'm not sure why you are asking for Aurora, given that the fix is already integrated in the latest release.