1169585 - MobileConnection marionette-webapi test, test_mobile_preferred_network_type.js, failed on emulator-kk

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Emulator, defect)

Description

[Edgar Chen [:edgar]]

https://treeherder.allizom.org/#/jobs?repo=try&revision=6794612b4298&filter-searchStr=mnw&exclusion_profile=false

16:39:24    ERROR -  TEST-UNEXPECTED-FAIL | test_mobile_preferred_network_type.js | setPreferredNetworkType success - false was false, expected true
16:39:24    ERROR -  TEST-UNEXPECTED-FAIL | test_mobile_preferred_network_type.js | getPreferredNetworkType success - got wcdma/gsm-auto, expected lte/wcdma

Comment 1

[Edgar Chen [:edgar]]

I can reproduce this failure on emulator-x86-kk locally. Looks like something related to the new preferred network type we added in bug 1160123, but emulator-ics doesn't have such problem. Need to figure out why it failed on emulator-kk.

Comment 2

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar][:echen] from comment #1)
> I can reproduce this failure on emulator-x86-kk locally. Looks like
> something related to the new preferred network type we added in bug 1160123,
> but emulator-ics doesn't have such problem. Need to figure out why it failed
> on emulator-kk.

hardware/ril doesn't support LTE/WCDMA as preferred mode [1]. When setting preferred mode to LTE/WCDMA, we get an unpredictable result due to reference-ril access a memory address which is out of net2modem/net2pmask array boundary.

https://github.com/mozilla-b2g/platform_hardware_ril/blob/master/reference-ril/reference-ril.c#L103-L131

Comment 3

[Edgar Chen [:edgar]]

Attachment: [platform_hardware_ril:master] PR #58

Comment 4

[Edgar Chen [:edgar]]

Attachment: [platform_hardware_ril:b2g-ril_v7] PR #59

Comment 5

[Edgar Chen [:edgar]]

try result: https://treeherder.allizom.org/#/jobs?repo=try&revision=eef25619e7c8&exclusion_profile=false

Comment 6

[Edgar Chen [:edgar]]

Comment on attachment 8613991 [details] [review]
[platform_hardware_ril:master] PR #58

Hi Hsinyi, would you mind reviewing this? Thank you.

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Sorry I'll catch this up early next week!

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Edgar Chen [:edgar][:echen] from comment #2)
> (In reply to Edgar Chen [:edgar][:echen] from comment #1)
> > I can reproduce this failure on emulator-x86-kk locally. Looks like
> > something related to the new preferred network type we added in bug 1160123,
> > but emulator-ics doesn't have such problem. Need to figure out why it failed
> > on emulator-kk.
> 
> hardware/ril doesn't support LTE/WCDMA as preferred mode [1]. When setting
> preferred mode to LTE/WCDMA, we get an unpredictable result due to
> reference-ril access a memory address which is out of net2modem/net2pmask
> array boundary.
> 
> https://github.com/mozilla-b2g/platform_hardware_ril/blob/master/reference-
> ril/reference-ril.c#L103-L131

Interesting!

Comment 9

[Edgar Chen [:edgar]]

master:
https://github.com/mozilla-b2g/platform_hardware_ril/commit/2b62676f02abb7633aac619e0f92c7fd70216860

b2g-ril_v7:
https://github.com/mozilla-b2g/platform_hardware_ril/commit/87a2d8ab9248540910e56921654367b78a587095