1169613 - Use content type of synthesized response for JAR channel requests if available

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

We are currently inferring the content type from the URL of the request, but that should not necessarily be the same as the on specified in the synthesized response.

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Working on tests now

Comment 2

[Josh Matthews [:jdm]]

Comment on attachment 8613457 [details] [diff] [review]
v1

Review of attachment 8613457 [details] [diff] [review]:
-----------------------------------------------------------------

This should have a test, too. I think we can perform an XHR to an ".txt" app url that is intercepted and set the responseType to "document", then sythesize a text/html response and check that xhr.response is a Document object once the request is complete.

::: modules/libjar/nsJARChannel.cpp
@@ +896,5 @@
>  }
>  
>  void
> +nsJARChannel::OverrideWithSynthesizedResponse(nsIInputStream* aSynthesizedInput,
> +                                              nsCString aContentType)

const nsACString&

@@ +917,5 @@
>        aSynthesizedInput->Close();
>        return;
>      }
>  
> +    mContentType = aContentType;

Call SetContentType instead.

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Part 1: Set Content-Type on synthesized response

r=jdm from comment 2

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Part 2: Set Content-Type on Fetch API response

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Part 3: Tests

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf8a4b45e3da
https://hg.mozilla.org/integration/mozilla-inbound/rev/99fc1ca23701
https://hg.mozilla.org/integration/mozilla-inbound/rev/52256ba02d2e

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bf8a4b45e3da
https://hg.mozilla.org/mozilla-central/rev/99fc1ca23701
https://hg.mozilla.org/mozilla-central/rev/52256ba02d2e