If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

The chromeUI icon in the identity-popup is blurry on Windows HiDPI

RESOLVED FIXED in Firefox 40

Status

()

Firefox
Theme
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 41
Points:
2
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox40 fixed, firefox41 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Comment hidden (empty)
Created attachment 8612957 [details] [diff] [review]
Patch
Attachment #8612957 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8612957 [details] [diff] [review]
Patch

Review of attachment 8612957 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/identity-block.inc.css
@@ +161,5 @@
>    }
> +
> +  #identity-popup.chromeUI > #identity-popup-container > #identity-popup-icon {
> +    list-style-image: url("chrome://branding/content/icon128.png");
> +    -moz-image-region: rect(0, 128px, 128px, 0);

NB: the -moz-image-region is needed in the shared file for the chromeUI because we don't have HiDPI icons for identity.png on Linux and Windows. It's also defined in the OSX file for #identity-popup-icon but I don't want to move that generic rule here since we are missing the identity@2x.png image and it will cause the 1x graphic to look worse in the interim.
Attachment #8612957 - Flags: review?(gijskruitbosch+bugs) → review+
Comment hidden (typo)
Comment hidden (typo)
Attachment #8612984 - Attachment is obsolete: true
Attachment #8612984 - Flags: review?(ehsan)
Keywords: checkin-needed

Comment 5

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/59226e937b85
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/59226e937b85
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Created attachment 8627207 [details] [diff] [review]
Patch for 40

Approval Request Comment
[Feature/regressing bug #]: Windows 10 HiDPI
[User impact if declined]: HiDPI icons on Windows are blurry
[Describe test coverage new/current, TreeHerder]: on mozilla-central for much of 41-nightly
[Risks and why]: none expected 
[String/UUID change made/needed]: none

https://hg.mozilla.org/try/pushloghtml?changeset=71084a9edf1e
Attachment #8627207 - Flags: approval-mozilla-beta?
status-firefox40: --- → affected
Comment on attachment 8627207 [details] [diff] [review]
Patch for 40

Visual fix in support of Windows 10. On m-c for more than a month. Beta+
Attachment #8627207 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/47135c037481
status-firefox40: affected → fixed
You need to log in before you can comment on or make changes to this bug.