Closed Bug 1169718 Opened 9 years ago Closed 9 years ago

[CL] Margin on right of "Open" buttons

Categories

(Firefox OS Graveyard :: Gaia::Customizer, defect, P2)

Product:
Firefox OS Graveyard
Component:
Gaia::Customizer
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: drs, Assigned: pdahiya)

References

Details

(Whiteboard: [spark])

Attachments

(1 file)

PR with fix of bug 1169718
51 bytes, text/x-github-pull-request
justindarc
: review+
Details | Review 
There's a small margin to the right of the "Open" buttons. We should remove it and make the buttons flush with the right edge of the container list.
Punam, can you take this?
Blocks: spark-customizer-launcher
Flags: needinfo?(pdahiya)
Priority: -- → P2
Whiteboard: [spark]
Assignee: nobody → pdahiya
Flags: needinfo?(pdahiya)
Assigning myself to work on this.
Hi Doug

Attaching PR that fixes margin on right of open buttons. Please review. Thanks!
Attachment #8613148 - Flags: review?(drs)
Comment on attachment 8613148 [details] [review]
PR with fix of bug 1169718

I don't know this app very well. Justin, could you review this instead?
Attachment #8613148 - Flags: review?(drs) → review?(jdarcangelo)
Comment on attachment 8613148 [details] [review]
PR with fix of bug 1169718

LGTM
Attachment #8613148 - Flags: review?(jdarcangelo) → review+
Thanks Justin! Patch landed on master

https://github.com/fxos/customizer-launcher/commit/59f1f9f91b0c8dbc105468015e025c4537df8d2f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: