1169729 - Unable to simply determine the cause of the Windows debug xpcshell 'INFO Failed to remove directory' for the temp directories

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Robert Strong (they/them - no direct email)]

There are a lot of "INFO Failed to remove directory:..." messages for Windows debug build xpcshell test runs and it should be possible to determine whether it is the profile or the plugins directory.

In runxpcshelltests.py the calls to mkdtemp for the profile and the plugins directories should include something like mkdtemp(prefix='profile-') for the profile directory and mkdtemp(prefix='plugins-') for the plugins directory.

This simple change should make it possible to see how often the directory removal fails for each type of directory (in my local testing it is always the plugins directory). From there it can be determined if tests would finish faster if they weren't given a plugins directory when they don't need one which could make tests complete faster for Windows debug.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: simple patch to make it clear that the failed dir removal is for the plugins dir

Comment 2

[Robert Strong (they/them - no direct email)]

Might be a good thing to add prefixes to all of the mkdtemp calls.

Perhaps something like xpc-plugins, xpc-profile, and xpc-other so they are sorted in the tmp dir for easy removal when breaking out of tests.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8613061 [details] [diff] [review]
simple patch to make it clear that the failed dir removal is for the plugins dir

Review of attachment 8613061 [details] [diff] [review]:
-----------------------------------------------------------------

Good thinking!

Comment 4

[(not currently active) Ted Mielczarek]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #2)
> Might be a good thing to add prefixes to all of the mkdtemp calls.
> 
> Perhaps something like xpc-plugins, xpc-profile, and xpc-other so they are
> sorted in the tmp dir for easy removal when breaking out of tests.

Yeah that seems totally reasonable. r=me to add that.

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: updated patch

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/fabf2c87d714

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fabf2c87d714