Unable to simply determine the cause of the Windows debug xpcshell 'INFO Failed to remove directory' for the temp directories

RESOLVED FIXED in Firefox 41

Status

Testing
XPCShell Harness
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

unspecified
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

There are a lot of "INFO Failed to remove directory:..." messages for Windows debug build xpcshell test runs and it should be possible to determine whether it is the profile or the plugins directory.

In runxpcshelltests.py the calls to mkdtemp for the profile and the plugins directories should include something like mkdtemp(prefix='profile-') for the profile directory and mkdtemp(prefix='plugins-') for the plugins directory.

This simple change should make it possible to see how often the directory removal fails for each type of directory (in my local testing it is always the plugins directory). From there it can be determined if tests would finish faster if they weren't given a plugins directory when they don't need one which could make tests complete faster for Windows debug.
Created attachment 8613061 [details] [diff] [review]
simple patch to make it clear that the failed dir removal is for the plugins dir
Attachment #8613061 - Flags: review?(ted)
Might be a good thing to add prefixes to all of the mkdtemp calls.

Perhaps something like xpc-plugins, xpc-profile, and xpc-other so they are sorted in the tmp dir for easy removal when breaking out of tests.
Assignee: nobody → robert.strong.bugs
Comment on attachment 8613061 [details] [diff] [review]
simple patch to make it clear that the failed dir removal is for the plugins dir

Review of attachment 8613061 [details] [diff] [review]:
-----------------------------------------------------------------

Good thinking!
Attachment #8613061 - Flags: review?(ted) → review+
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #2)
> Might be a good thing to add prefixes to all of the mkdtemp calls.
> 
> Perhaps something like xpc-plugins, xpc-profile, and xpc-other so they are
> sorted in the tmp dir for easy removal when breaking out of tests.

Yeah that seems totally reasonable. r=me to add that.
Created attachment 8613651 [details] [diff] [review]
updated patch
Attachment #8613061 - Attachment is obsolete: true
Attachment #8613651 - Flags: review+

Comment 6

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/fabf2c87d714
https://hg.mozilla.org/mozilla-central/rev/fabf2c87d714
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.