Closed Bug 1169754 Opened 5 years ago Closed 5 years ago

Persist state that Firefox was a user's default browser

Categories

(Firefox :: General, defect)

defect
Not set
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 41
Iteration:
41.2 - Jun 8
Tracking Status
firefox39 --- fixed
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

After upgrading from Windows 8 to Windows 10, the default browser will most likely be reset. It will be good to store this state independently of the OS prior to upgrade so we have the ability to alter our messaging if the user previously had Firefox set as the default.

[Tracking Requested - why for this release]:
Requesting tracking for Firefox 39 because we will need to get this out ASAP on to Release before Windows 10 gets released if we want to use this.
Attached patch Patch (obsolete) — Splinter Review
Attachment #8613044 - Flags: review?(gijskruitbosch+bugs)
Attached patch Patch (qref'd)Splinter Review
Attachment #8613044 - Attachment is obsolete: true
Attachment #8613044 - Flags: review?(gijskruitbosch+bugs)
Attachment #8613047 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8613047 [details] [diff] [review]
Patch (qref'd)

This is safe, trivial, and seems handy to have. But I suspect we'll need to do more before actually building something around it.
Attachment #8613047 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 8613047 [details] [diff] [review]
Patch (qref'd)

Approval Request Comment
[Feature/regressing bug #]: windows 10 upgrade path
[User impact if declined]: less information upon upgrading
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: safe low risk, only sets a pref using data we already had
[String/UUID change made/needed]: none
Attachment #8613047 - Flags: approval-mozilla-beta?
Attachment #8613047 - Flags: approval-mozilla-aurora?
I see the following with an fx-team custom build:

TypeError: Services.setBoolPref is not a function in nsBrowserGlue.js
Flags: needinfo?(jaws)
https://hg.mozilla.org/mozilla-central/rev/012c47aa86b5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Flags: needinfo?(jaws)
Attachment #8613047 - Flags: approval-mozilla-beta?
Attachment #8613047 - Flags: approval-mozilla-aurora?
Depends on: 1170284
Affects Firefox 39, so tracking.
It seems like the the patch for bug 1170304 completely revokes the change made by the patch attached to this bug. "dolske" agrees on that. Removing the tracking flag for firefox39.

Renominate if you think this is a separate issue.
You need to log in before you can comment on or make changes to this bug.