116982 - MacOS X do not render Hebrew correctly

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Frank Tang]

on MacOS X, hebrew display incorrectly even after we fix bug 116976. 

in 562 NS_IMETHODIMP nsRenderingContextMac::GetHints(PRUint32& aResult)

we currently always set BIDI and ARBIC shapping on.
571 result |= NS_RENDERING_HINT_BIDI_REORDERING;
572 result |= NS_RENDERING_HINT_ARABIC_SHAPING;

we should depend on the script system. If Hebrew script is installed, set
NS_RENDERING_HINT_BIDI_REORDERING on. If Arabic script is installed, set both
flag on.

Comment 1

[Frank Tang]

Attachment: turn on bidi flag depend on the script system

Comment 2

[Frank Tang]

sfraser, can you r= this one. We need this patch and the fix in 116976 to fix
MacOS X Hebrew rendering.

Comment 3

[Nissan Zafrir]

please , make sure you dont go by the leading system script .
you should only check if the script is installed . Because most
Hebrew users , their system is configuered with Roman Script
as the leading Script and not Hebrew ( Since OS 9.1 )

Comment 4

[Simon Fraser [no longer active]]

The code in the patch just asks if a script is enabled, not whether it's the 
system script, so I think that's OK. sr=sfraser

Comment 5

[Frank Tang]

thanks

Comment 6

[Frank Tang]

Comment on attachment 62785 [details] [diff] [review]
turn on bidi flag depend on the script system

http://bugzilla.mozilla.org/attachment.cgi?id=62920&action=view in bug 107098
obsolete this patch

Comment 7

[Frank Tang]

I believe the following three patch should fix most mac os hewbrew problem

big endian issue in nsFrame.cpp
see latest patch in http://bugzilla.mozilla.org/show_bug.cgi?id=116976

big endian issue in nsBidiImp.cpp 
http://bugzilla.mozilla.org/attachment.cgi?id=62917&action=view

turn off hebrew reordering and do not report hint on mac gfx
http://bugzilla.mozilla.org/attachment.cgi?id=62920&action=view

Comment 8

[Frank Tang]

this should be fixed right now.