MacOS X do not render Hebrew correctly

RESOLVED FIXED in mozilla0.9.8

Status

()

Core
Layout: Text
RESOLVED FIXED
16 years ago
10 years ago

People

(Reporter: Frank Tang, Assigned: Frank Tang)

Tracking

Trunk
mozilla0.9.8
PowerPC
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Assignee)

Description

16 years ago
on MacOS X, hebrew display incorrectly even after we fix bug 116976. 

in 562 NS_IMETHODIMP nsRenderingContextMac::GetHints(PRUint32& aResult)

we currently always set BIDI and ARBIC shapping on.
571 result |= NS_RENDERING_HINT_BIDI_REORDERING;
572 result |= NS_RENDERING_HINT_ARABIC_SHAPING;

we should depend on the script system. If Hebrew script is installed, set
NS_RENDERING_HINT_BIDI_REORDERING on. If Arabic script is installed, set both
flag on.
(Assignee)

Comment 1

16 years ago
Created attachment 62785 [details] [diff] [review]
turn on bidi flag depend on the script system
(Assignee)

Comment 2

16 years ago
sfraser, can you r= this one. We need this patch and the fix in 116976 to fix
MacOS X Hebrew rendering.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.8
(Assignee)

Updated

16 years ago
Blocks: 104056
(Assignee)

Updated

16 years ago
Blocks: 74125
(Assignee)

Updated

16 years ago
Blocks: 80577
(Assignee)

Updated

16 years ago
Blocks: 96305
(Assignee)

Updated

16 years ago
Blocks: 110655
(Assignee)

Updated

16 years ago
Blocks: 111967
(Assignee)

Updated

16 years ago
No longer blocks: 110655
(Assignee)

Updated

16 years ago
Blocks: 117028

Comment 3

16 years ago
please , make sure you dont go by the leading system script .
you should only check if the script is installed . Because most
Hebrew users , their system is configuered with Roman Script
as the leading Script and not Hebrew ( Since OS 9.1 )

Comment 4

16 years ago
The code in the patch just asks if a script is enabled, not whether it's the 
system script, so I think that's OK. sr=sfraser
(Assignee)

Comment 5

16 years ago
thanks
Blocks: 104060
No longer blocks: 104056
(Assignee)

Comment 6

16 years ago
Comment on attachment 62785 [details] [diff] [review]
turn on bidi flag depend on the script system

http://bugzilla.mozilla.org/attachment.cgi?id=62920&action=view in bug 107098
obsolete this patch
Attachment #62785 - Attachment is obsolete: true
(Assignee)

Comment 7

16 years ago
I believe the following three patch should fix most mac os hewbrew problem

big endian issue in nsFrame.cpp
see latest patch in http://bugzilla.mozilla.org/show_bug.cgi?id=116976

big endian issue in nsBidiImp.cpp 
http://bugzilla.mozilla.org/attachment.cgi?id=62917&action=view

turn off hebrew reordering and do not report hint on mac gfx
http://bugzilla.mozilla.org/attachment.cgi?id=62920&action=view
(Assignee)

Updated

16 years ago
No longer blocks: 104060
(Assignee)

Comment 8

16 years ago
this should be fixed right now.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Assignee)

Updated

16 years ago
Blocks: 104060
(Assignee)

Updated

16 years ago
No longer blocks: 104060

Updated

10 years ago
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: zach → layout.fonts-and-text
You need to log in before you can comment on or make changes to this bug.