Closed
Bug 1169869
Opened 9 years ago
Closed 9 years ago
[jsdbg2] document the onPromiseSettled hook
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file)
|
3.18 KB,
patch
|
jimb
:
review+
|
Details | Diff | Splinter Review |
I guess I forgot to add docs for this hook when I landed it.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8614841 -
Flags: review?(jimb)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8614841 [details] [diff] [review] Document the Debugger's onPromiseSettled hook Review of attachment 8614841 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/doc/Debugger/Debugger.md @@ +107,5 @@ > + ("continue normally"); <i>value</i> is ignored. > + > +<code>onPromiseSettled(<i>promise</i>)</code> > +: A Promise object, referenced by the [`Debugger.Object`][object] instance > + *promise*, has settled (either fulfilled or rejected). The Promise's state I think this should specify that it reports *debuggee* promises, not just random promises anywhere on the system. (We do have hooks like onNewGlobalObject that watch everything.)
Attachment #8614841 -
Flags: review?(jimb) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/c42a875da455
Whiteboard: [fixed-in-fx-team]
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c42a875da455
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•