Closed Bug 1169869 Opened 5 years ago Closed 5 years ago

[jsdbg2] document the onPromiseSettled hook

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file)

I guess I forgot to add docs for this hook when I landed it.
Depends on: 1084065
Comment on attachment 8614841 [details] [diff] [review]
Document the Debugger's onPromiseSettled hook

Review of attachment 8614841 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/doc/Debugger/Debugger.md
@@ +107,5 @@
> +    ("continue normally"); <i>value</i> is ignored.
> +
> +<code>onPromiseSettled(<i>promise</i>)</code>
> +:   A Promise object, referenced by the [`Debugger.Object`][object] instance
> +    *promise*, has settled (either fulfilled or rejected). The Promise's state

I think this should specify that it reports *debuggee* promises, not just random promises anywhere on the system. (We do have hooks like onNewGlobalObject that watch everything.)
Attachment #8614841 - Flags: review?(jimb) → review+
https://hg.mozilla.org/mozilla-central/rev/c42a875da455
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.