The 'Trigger a try build' button should be disabled unless the review has been published

RESOLVED FIXED

Status

MozReview
General
P1
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: francois, Assigned: dminor)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
The UI makes it possible to request a Try run on a draft review (before it's published) but it fails with a generic error message.

Ideally, that option should be hidden until the review has been published.
(Assignee)

Comment 1

3 years ago
Like François says, Try runs on draft reviews don't work properly. In Bug 1170380, previously published commits were sent to Try rather than the draft commits. We should disable the 'Try' button unless the review has been published.
Priority: -- → P1
Summary: Requesting a try run on a draft review doesn't work → The 'Trigger a try build' button should be disabled unless the review has been published
(Assignee)

Updated

3 years ago
Duplicate of this bug: 1170380
(Assignee)

Updated

3 years ago
Assignee: nobody → dminor
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 years ago
Created attachment 8613852 [details]
MozReview Request: mozreview: disable 'Try' button unless review has been published (bug 1169898); r?mdoglio

mozreview: disable 'Try' button unless review has been published (bug 1169898); r?mdoglio

Attempting a 'Try' run on a draft review will fail or cause a Try run to be
started using previously published commits. We should disable the button unless
the draft has been published.
Attachment #8613852 - Flags: review?(mdoglio)
Comment on attachment 8613852 [details]
MozReview Request: mozreview: disable 'Try' button unless review has been published (bug 1169898); r?mdoglio

https://reviewboard.mozilla.org/r/9815/#review8643

Ship It!
Attachment #8613852 - Flags: review?(mdoglio) → review+
https://reviewboard.mozilla.org/r/9813/#review8645
(Assignee)

Comment 6

3 years ago
Thanks, pushed to: https://hg.mozilla.org/hgcustom/version-control-tools/rev/04688f7ff035
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.