Closed Bug 1169901 Opened 11 years ago Closed 11 years ago

View source: missing specific commands in context menu when clicking outside the code section on short pages

Categories

(Toolkit :: View Source, defect)

Product:
Toolkit
Component:
View Source
Version:
41 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox41 + fixed

People

(Reporter: alice0775, Assigned: jryans)

References

(
URL
)

Details

(Keywords: regression, ux-consistency, Whiteboard: [bugday-20150902])

Attachments

(2 files)

screenshot bug
29.37 KB, image/png
Details
MozReview Request: Bug 1169901 - View source menu covers full height. r=mconley
39 bytes, text/x-review-board-request
heycam
: review+
jryans
: review+
Details
[Tracking Requested - why for this release]: This is very bad usability. Steps To reproduce: 1. Open any page ( ex data:text/html,<body><p>bra bra</p><p>bra bra</p></body> ) 2. Execute "View Page Source" or "View Selection Source" 3. Right click on empty area under the source. Actual Results: No context menu for view source. General context menu is shown. Expected Results: "Go to Line", "Wrap Long Line" and "Syntax Highlighting" should be shown.
Attached image screenshot bug —
Summary: No context menu for view source → View source: missing specific commands in context menu when clicking outside the code section on short pages
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Firefox 41 is affected, and it is a usability issue, so tracking Firefox 41.
tracking-firefox41: ? → +
Attachment #8614396 - Flags: review?(mconley) → review+
Comment on attachment 8614396 [details] MozReview Request: Bug 1169901 - View source menu covers full height. r=mconley https://reviewboard.mozilla.org/r/9937/#review8889 This looks fine to me - however, this is under layout, where I am not a peer. Not sure if somebody from layout wants to rubberstamp it, but maybe ask around in #layout?
Comment on attachment 8614396 [details] MozReview Request: Bug 1169901 - View source menu covers full height. r=mconley Bug 1169901 - View source menu covers full height. r=mconley
Attachment #8614396 - Flags: review?(mconley)
Attachment #8614396 - Flags: review?(cam)
Attachment #8614396 - Flags: review+
Comment on attachment 8614396 [details] MozReview Request: Bug 1169901 - View source menu covers full height. r=mconley mconley gave r+. No response in #layout, so chose :heycam from the module list.
Attachment #8614396 - Flags: review?(mconley) → review+
Comment on attachment 8614396 [details] MozReview Request: Bug 1169901 - View source menu covers full height. r=mconley https://reviewboard.mozilla.org/r/9937/#review8899 Looks fine, thanks.
Attachment #8614396 - Flags: review?(cam) → review+
https://hg.mozilla.org/mozilla-central/rev/57230152b004
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
QA Whiteboard: [good first verify]
I have reproduced this bug in Nightly 41.0a1(Build ID: 20150530030205)(Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:41.0) Gecko/20100101 Firefox/41.0 Verified as fixed on latest nightly Edition 43.0a1 (Build ID: 20150901030226) Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:43.0) Gecko/20100101 Firefox/43.0 [Bugday-20150902]
QA Whiteboard: [good first verify] → [good first verify][bugday-20150902]
Whiteboard: [bugday-20150902]
Please avoid my earlier comment which was done in mistake! I have reproduced this bug in Nightly 41.0a1 (Build ID 20150530030205) Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0 Verified as fixed on beta 41.0b6 (Build ID 20150831172306) Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0 [Bugday-20150902]
As per comment 13, changing the status VERIFIED FIXED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: