Use less noisy pylint/landscape.io configs

RESOLVED FIXED

Status

Tree Management
Treeherder: Docs & Development
P3
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Details

Attachments

(1 attachment)

To help with bug 1169938, we should:
(a) check a pylintrc into the repo with sensible defaults (since otherwise we just use landscape.io's defaults - and also have no way to repro locally)
(b) tweak .landscape.yaml to reduce the number of false positives (eg turn off warnings for tests, at least initially)
Created attachment 8613240 [details] [review]
Use less noisy pylint/landscape.io configs
Attachment #8613240 - Flags: review?(cdawson)

Updated

3 years ago
Attachment #8613240 - Flags: review?(cdawson) → review+

Comment 2

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/7ccb6b2d6a2272845786948b90d5c4f3dd80d5e2
Bug 1169939 - Switch .landscape.yaml to 2-space indent

https://github.com/mozilla/treeherder/commit/16ef326225935dc35332baeea27593d5153fc8c9
Bug 1169939 - Tweak .landscape.yaml to improve signal to noise ratio

* Turns off warnings for tests (there are particularly noisy due to
  mocking - we can always turn this back on later).
* Ignores some files/folders that are either for third party code, or
  else don't play nicely with pylint/landscape.io (eg update.py, since
  commander isn't installed).
* Adds the prod.txt requirements file, so landscape.io can resolve the
  New Relic package references.

https://github.com/mozilla/treeherder/commit/e60a96bdf29c2eab9ea5927906b01b4aa2e07f5a
Bug 1169939 - Add a first pass at a pylintrc to the repo

Uses many of the defaults from prospector (used by landscape.io):
https://github.com/landscapeio/prospector/tree/master/prospector/profiles/profiles

...particularly those in `strictness_{veryhigh,high,medium}.yaml`

landscape.io will now use this file instead of its own defaults.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.