Closed Bug 1169954 Opened 6 years ago Closed 6 years ago

Position the popup notification close button on Linux as done on Windows

Categories

(Toolkit :: Themes, defect)

Unspecified
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: dao, Assigned: dao)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
No description provided.
Attachment #8613257 - Flags: review?(MattN+bmo)
Attachment #8613257 - Flags: review?(MattN+bmo) → review?(gijskruitbosch+bugs)
Comment on attachment 8613257 [details] [diff] [review]
patch

This puts the button veeeeeeery close to the edge of the notification box, from a quick investigation, it seems that's because the panel's "arrowcontent" doesn't have any margin of its own, whereas it has a 4px margin on Windows. (to be clear: the result doesn't look the same as the Windows case)

We could either change the values here to be smaller than those on Windows, or "equalize" more of the CSS so that the same values work. The latter is probably more work but better in the long term? I'm not sure which I would prefer because I don't know what prompted you to make this change. Elaborating on that a little bit would probably be helpful, if only for archaeology's sake in 6 months / 3 years' time. :-)
Attachment #8613257 - Flags: review?(gijskruitbosch+bugs)
Attached patch patch v2Splinter Review
(In reply to :Gijs Kruitbosch from comment #1)
> Comment on attachment 8613257 [details] [diff] [review]
> patch
> 
> This puts the button veeeeeeery close to the edge of the notification box,
> from a quick investigation, it seems that's because the panel's
> "arrowcontent" doesn't have any margin of its own, whereas it has a 4px
> margin on Windows. (to be clear: the result doesn't look the same as the
> Windows case)

That margin is probably there because arrow panels have a drop shadow on Windows but not on Linux.

> I don't know what prompted you to make this change.
> Elaborating on that a little bit would probably be helpful, if only for
> archaeology's sake in 6 months / 3 years' time. :-)

The idea is to have the close button closer attached to the border rather than floating around in the middle of nowhere.
Attachment #8613257 - Attachment is obsolete: true
Attachment #8614637 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8614637 [details] [diff] [review]
patch v2

Review of attachment 8614637 [details] [diff] [review]:
-----------------------------------------------------------------

This kind of margin looks about right to me, so rs=me
Attachment #8614637 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/e56c2ee5836e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.