1169954 - Position the popup notification close button on Linux as done on Windows

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[:Gijs (he/him)]

Comment on attachment 8613257 [details] [diff] [review]
patch

This puts the button veeeeeeery close to the edge of the notification box, from a quick investigation, it seems that's because the panel's "arrowcontent" doesn't have any margin of its own, whereas it has a 4px margin on Windows. (to be clear: the result doesn't look the same as the Windows case)

We could either change the values here to be smaller than those on Windows, or "equalize" more of the CSS so that the same values work. The latter is probably more work but better in the long term? I'm not sure which I would prefer because I don't know what prompted you to make this change. Elaborating on that a little bit would probably be helpful, if only for archaeology's sake in 6 months / 3 years' time. :-)

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch v2

(In reply to :Gijs Kruitbosch from comment #1)
> Comment on attachment 8613257 [details] [diff] [review]
> patch
> 
> This puts the button veeeeeeery close to the edge of the notification box,
> from a quick investigation, it seems that's because the panel's
> "arrowcontent" doesn't have any margin of its own, whereas it has a 4px
> margin on Windows. (to be clear: the result doesn't look the same as the
> Windows case)

That margin is probably there because arrow panels have a drop shadow on Windows but not on Linux.

> I don't know what prompted you to make this change.
> Elaborating on that a little bit would probably be helpful, if only for
> archaeology's sake in 6 months / 3 years' time. :-)

The idea is to have the close button closer attached to the border rather than floating around in the middle of nowhere.

Comment 3

[:Gijs (he/him)]

Comment on attachment 8614637 [details] [diff] [review]
patch v2

Review of attachment 8614637 [details] [diff] [review]:
-----------------------------------------------------------------

This kind of margin looks about right to me, so rs=me

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e56c2ee5836e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e56c2ee5836e