Closed
Bug 1169959
Opened 10 years ago
Closed 10 years ago
cleanup hack for talos android to have nonlocal connections allowed for tprovider
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(firefox41 affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | affected |
People
(Reporter: jmaher, Assigned: jmaher)
Details
Attachments
(1 file)
|
1.79 KB,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
we don't run tprovider anymore, so we don't need the specific hack from bug 1026970
|
Assignee | |
Comment 1•10 years ago
|
||
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8613262 [details] [diff] [review]
remove tprovider check (1.0)
Review of attachment 8613262 [details] [diff] [review]:
-----------------------------------------------------------------
::: talos/profiler/sps.py
@@ +8,1 @@
> def save_profile(profile, filename):
I'd probably leave these changes out. I believe :parkouss has a patch pending to pep8ify talos, which should fix this.
Attachment #8613262 -
Flags: review?(wlachance) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
thanks! I will land this after the pep8 patch so that we don't have to redo work.
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•