1170011 - A view source tab shouldn't have a "View Page Source" option (or else holding down "Ctrl+U" spawns zillions of view-source:view-source:view-source:... tabs)

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[Francesco Lodolo [:flod]]

Select View Source on a page, source opens in a new tab.

1) The context menu still has a "View Page Source" option, which probably shouldn't be there.

2) If you select "View Page Source", or press CTRL+U, you end up in a page that looks like a plain text file, without any syntax highlighting (even if the menu item is selected), and you can keep going inception-style.

Comment 1

[Daniel Holbert [:dholbert]]

I was about to file a new bug, but I think it's basically the same as this one.

My STR:
 1. Visit some site, e.g. https://www.mozilla.org/en-US/
 2. Press Ctrl+U to view-source. Hold these keys down for a second or two.

ACTUAL RESULTS: I first get a new tab at...
>  view-source:https://www.mozilla.org/en-US/
...and then suddenly, more new tabs start *rapidly* spawning, with these URLs:
> view-source:view-source:https://www.mozilla.org/en-US/
> view-source:view-source:view-source:https://www.mozilla.org/en-US/
> view-source:view-source:view-source:view-source:https://www.mozilla.org/en-US/
etc etc.

EXPECTED RESULTS: No rapidly-spawning view-source:view-source: tabs.

Comment 2

[Dave Townsend [:mossop]]

ISTR mconley implemented this

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Dave Townsend [:mossop] from comment #2)
> ISTR mconley implemented this

I am the culprit I think. :)

Comment 4

[(no longer active)]

Attachment: Disable infinite recursion on the View Source command

This disables the View Source command on view-source documents in the
view-source-in-tab mode.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8652070 [details] [diff] [review]
Disable infinite recursion on the View Source command

Review of attachment 8652070 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/general/browser_viewSourceInTabOnViewSource.js
@@ +5,5 @@
> +                              ]}, resolve);
> +  });
> +});
> +
> +add_task(function* test_page() {

test_regular_page

@@ +6,5 @@
> +  });
> +});
> +
> +add_task(function* test_page() {
> +  function* test_on_browser(browser) {

test_expect_view_source_enabled

@@ +17,5 @@
> +    url: "http://example.com",
> +  }, test_on_browser);
> +});
> +
> +add_task(function* test_page() {

test_view_source_page

@@ +18,5 @@
> +  }, test_on_browser);
> +});
> +
> +add_task(function* test_page() {
> +  function* test_on_browser(browser) {

test_expect_view_source_disabled

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/de77ab24fab9

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Backed out for browser_viewSourceInTabOnViewSource.js failures.
https://treeherder.mozilla.org/logviewer.html#?job_id=13306752&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/60383e5c8e4e

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7402272f257

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Backed out for more browser_viewSourceInTabOnViewSource.js failures. Please verify that this is green on Try before attempting to re-land again.
https://treeherder.mozilla.org/logviewer.html#?job_id=13324210&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/b15e2623ea80

Comment 10

[(no longer active)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bcfa1fdcfa5e

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4dcf5d8245e

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b4dcf5d8245e